You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/11 04:11:51 UTC
[GitHub] [incubator-shardingsphere] yuzel opened a new pull request #4704:
#4482 Correct the DataTypeName for Oracle.
yuzel opened a new pull request #4704: #4482 Correct the DataTypeName for Oracle.
URL: https://github.com/apache/incubator-shardingsphere/pull/4704
ref #4482
Reference link
- [dataType](https://docs.oracle.com/en/database/oracle/oracle-database/20/lnpls/plsql-data-types.html#GUID-239A89A6-4CBC-46F5-8A6A-10E8B465B7E8)
- [plsql-predefined-data-types](https://docs.oracle.com/en/database/oracle/oracle-database/20/lnpls/plsql-predefined-data-types.html#GUID-1D28B7B6-15AE-454A-8134-F8724551AE8B)
- [createType](https://docs.oracle.com/en/database/oracle/oracle-database/20/sqlrf/CREATE-TYPE.html#GUID-F9CE0CC3-13AE-4744-A43C-EAC7A71AAAB6)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4704:
#4482 Correct the DataTypeName for Oracle.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597444311
@yuzel Good job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4704:
#4482 Correct the DataTypeName for Oracle.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597443789
## Pull Request Test Coverage Report for [Build 10171](https://coveralls.io/builds/29266892)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **18** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **59.023%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29266892/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29266892/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29266892/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
<!-- | **Total:** | **18** | | -->
| Totals | [](https://coveralls.io/builds/29266892) |
| :-- | --: |
| Change from base [Build 1043](https://coveralls.io/builds/29264643): | -0.08% |
| Covered Lines: | 12144 |
| Relevant Lines: | 20575 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4704:
#4482 Correct the DataTypeName for Oracle.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4704: #4482 Correct the DataTypeName for Oracle.
URL: https://github.com/apache/incubator-shardingsphere/pull/4704#issuecomment-597442800
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=h1) Report
> Merging [#4704](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/5daaca24e0dd714d810551a31541335fbdfb71fe?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4704 +/- ##
============================================
+ Coverage 55.43% 55.46% +0.02%
Complexity 426 426
============================================
Files 1136 1133 -3
Lines 20624 20575 -49
Branches 3827 3819 -8
============================================
- Hits 11432 11411 -21
+ Misses 8470 8443 -27
+ Partials 722 721 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/jdbc/core/statement/ShadowPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1ByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `40.9% <0%> (-3.54%)` | `0% <0%> (ø)` | |
| [...dingjdbc/jdbc/core/statement/EncryptStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRTdGF0ZW1lbnQuamF2YQ==) | `59.75% <0%> (-3.17%)` | `0% <0%> (ø)` | |
| [...rdingjdbc/jdbc/core/statement/ShadowStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYWRvd1N0YXRlbWVudC5qYXZh) | `64.17% <0%> (-2.95%)` | `0% <0%> (ø)` | |
| [.../jdbc/core/statement/EncryptPreparedStatement.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L0VuY3J5cHRQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `79.8% <0%> (-1.28%)` | `0% <0%> (ø)` | |
| [...impl/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByZWRpY2F0ZVJpZ2h0VmFsdWVUb2tlbkdlbmVyYXRvci5qYXZh) | `93.33% <0%> (ø)` | `1% <0%> (ø)` | :arrow_down: |
| [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1N0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `1.61% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...ewrite/sql/token/generator/SQLTokenGenerators.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvc3FsL3Rva2VuL2dlbmVyYXRvci9TUUxUb2tlbkdlbmVyYXRvcnMuamF2YQ==) | `21.87% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | | | |
| [...rlying/common/metadata/ShardingSphereMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL1NoYXJkaW5nU3BoZXJlTWV0YURhdGEuamF2YQ==) | | | |
| [...swapper/OrchestrationConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL3lhbWwvc3dhcHBlci9PcmNoZXN0cmF0aW9uQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | | | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=footer). Last update [5daaca2...6957a2f](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4704?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4704:
#4482 Correct the DataTypeName for Oracle.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4704: #4482 Correct the DataTypeName for Oracle.
URL: https://github.com/apache/incubator-shardingsphere/pull/4704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services