[GitHub] [arrow] projjal commented on a change in pull request #10464: ARROW-12943: [Gandiva][C++]Implement MD5 Hive function

[GitBox <gi...@apache.org>]

projjal commented on a change in pull request #10464:
URL: https://github.com/apache/arrow/pull/10464#discussion_r664828053



##########
File path: cpp/src/gandiva/hash_utils.h
##########
@@ -33,10 +33,14 @@ const char* gdv_hash_using_sha1(int64_t context, const void* message,
                                 size_t message_length, int32_t* out_length);
 
 GANDIVA_EXPORT
-const char* gdv_hash_using_sha(int64_t context, const void* message,
+const char* gdv_hash_using_ssl(int64_t context, const void* message,

Review comment:
       i think better name name it as gdv_hash_using_openssl(..) since ssl is just a library.
   Also rename gdv_hash_using_md5 and gdv_hash_using_sha1 as gdv_md5_hash and gdv_sha1_hash




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org