You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/08/18 03:40:30 UTC

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1631: Enable to stop the local iotdb service in the distributed environmen

neuyilan commented on a change in pull request #1631:
URL: https://github.com/apache/incubator-iotdb/pull/1631#discussion_r471895027



##########
File path: cluster/src/assembly/resources/sbin/stop-node.bat
##########
@@ -17,7 +17,12 @@
 @REM under the License.
 @REM
 
+

Review comment:
       delete the black line

##########
File path: cluster/src/assembly/resources/sbin/stop-node.sh
##########
@@ -20,11 +20,21 @@
 
 
 PIDS=$(ps ax | grep -i 'ClusterMain' | grep java | grep -v grep | awk '{print $1}')
-
-if [ -z "$PIDS" ]; then
-  echo "No IoTDB server to stop"
-  exit 1
-else 
-  kill -s TERM $PIDS
-  echo "close IoTDB"
+sig=0
+for evry_pid in ${PIDS}

Review comment:
       pay attention to  the code style




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org