You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Denis Kishenko (JIRA)" <ji...@apache.org> on 2006/12/04 12:44:23 UTC
[jira] Created: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
[classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
-----------------------------------------------------------------------------------------------------
Key: HARMONY-2406
URL: http://issues.apache.org/jira/browse/HARMONY-2406
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Denis Kishenko
For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
============ Test ==============
import java.awt.event.KeyEvent;
import java.awt.event.KeyEvent;
public class Test {
public static void main(String[] argv) {
KeyEvent.getKeyText(4);
}
}
========= RI ========
noting
======== Harmony =====
java.lang.StringIndexOutOfBoundsException
at java.lang.String.charAt(String.java:585)
at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465105 ]
Andrey Pavlenko commented on HARMONY-2406:
------------------------------------------
Sorry, I hadn't updated the test. Now everything is ok, you can close the issue.
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: https://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Assigned To: Mark Hindess
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2406?page=all ]
Andrey Pavlenko updated HARMONY-2406:
-------------------------------------
Attachment: KeyEvent.patch
KeyEventTest.patch
Attaching patch and regression test.
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: http://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2406?page=all ]
Alexei Zakharov updated HARMONY-2406:
-------------------------------------
Patch Info: [Patch Available]
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: http://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess closed HARMONY-2406.
---------------------------------
Verified. Thanks.
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: https://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Assigned To: Mark Hindess
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-2406.
-----------------------------------
Resolution: Fixed
Assignee: Mark Hindess
Applied patches in r495724. I modified the test to follow the project conventions for exception handling - that is, letting junit handle them.
Please confirm that the patches have been applied as expected.
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: https://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Assigned To: Mark Hindess
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464990 ]
Mark Hindess commented on HARMONY-2406:
---------------------------------------
Yes. You will find that line just after the comment "// Regression test for HARMONY-2406".
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: https://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Assigned To: Mark Hindess
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2406) [classlib][awt]
j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while
RI doesn't
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464938 ]
Andrey Pavlenko commented on HARMONY-2406:
------------------------------------------
Mark, is the patch for the test applied? I can't find KeyEvent.getKeyText(4); string in the test.
> [classlib][awt] j.a.e.KeyEvent.getKeyText(int) thows StringIndexOutOfBoundsException while RI doesn't
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2406
> URL: https://issues.apache.org/jira/browse/HARMONY-2406
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Denis Kishenko
> Assigned To: Mark Hindess
> Attachments: KeyEvent.patch, KeyEventTest.patch
>
>
> For java.awt.event.KeyEvent.getKeyText(int keyCode) method - Harmony throws java.lang.StringIndexOutOfBoundsException if keyCode does not equal a key constant for a physical key on the keyboard while RI does not. There is no mention about this situation in java spec
> ============ Test ==============
> import java.awt.event.KeyEvent;
> import java.awt.event.KeyEvent;
> public class Test {
> public static void main(String[] argv) {
> KeyEvent.getKeyText(4);
> }
> }
> ========= RI ========
> noting
> ======== Harmony =====
> java.lang.StringIndexOutOfBoundsException
> at java.lang.String.charAt(String.java:585)
> at java.awt.event.KeyEvent.getDefaultName(KeyEvent.java:486)
> at java.awt.event.KeyEvent.getKeyText(KeyEvent.java:474)
> at Test.main(Test.java:11)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira