You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by fr...@apache.org on 2017/12/06 09:30:57 UTC
svn commit: r1817274 -
/jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java
Author: frm
Date: Wed Dec 6 09:30:57 2017
New Revision: 1817274
URL: http://svn.apache.org/viewvc?rev=1817274&view=rev
Log:
OAK-7031 - Ensure that the temporary file is not accidentally leaked
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java
Modified: jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java?rev=1817274&r1=1817273&r2=1817274&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/GetBlobRequestHandlerTest.java Wed Dec 6 09:30:57 2017
@@ -24,6 +24,7 @@ import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import java.io.ByteArrayInputStream;
+import java.io.InputStream;
import io.netty.channel.embedded.EmbeddedChannel;
import org.apache.commons.io.IOUtils;
@@ -47,8 +48,10 @@ public class GetBlobRequestHandlerTest {
assertEquals("clientId", response.getClientId());
assertEquals("blobId", response.getBlobId());
assertEquals(blobData.length, response.getLength());
- byte[] receivedData = IOUtils.toByteArray(response.getInputStream());
- assertArrayEquals(blobData, receivedData);
+ try (InputStream is = response.getInputStream()) {
+ byte[] receivedData = IOUtils.toByteArray(is);
+ assertArrayEquals(blobData, receivedData);
+ }
}
@Test