You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/29 02:58:54 UTC
[GitHub] [skywalking-rocketbot-ui] heihaozi opened a new pull request #514: Fix the error of server response time in the topology.
heihaozi opened a new pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514
Fix #513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870193941
@Fine0830 Why there are metrics still hardcoded today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870363014
> > @Fine0830 Why there are metrics still hardcoded today?
>
> It's for computing the topology itself. I haven't updated code in the 8.6.0.
We should, but it is not urgent. Then this PR seems a correct fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870283391
Shall we use the v2 metric protocol to instead v1 metric protocol?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870193941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870381737
> > > @Fine0830 Why there are metrics still hardcoded today?
> >
> >
> > It's for computing the topology itself. I haven't updated code in the 8.6.0.
>
> We should, but it is not urgent. Then this PR seems a correct fix?
Yep. Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870279672
> @Fine0830 Why there are metrics still hardcoded today?
It's for computing the topology itself. I haven't updated code in the 8.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #514: Fix the error of server response time in the topology.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #514:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/514#issuecomment-870279672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org