You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/03 15:54:24 UTC

[GitHub] [flink] akalash opened a new pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

akalash opened a new pull request #17663:
URL: https://github.com/apache/flink/pull/17663


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *This PR fixes IllegalStateException during  new buffer size announcement when the channel is released already*
   
   
   ## Brief change log
   
     - *Ignore announcement new buffer size if the channel is released*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added new test in LocalInputChannelTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942) 
   * e95e8ceeb1b8990e029358dac5731e50415c7383 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-960611012


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742892354



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       I updated PR one more time. But my current solution considers that it is impossible to call `announceBufferSize` and `releaseAllResources` in parallel. But I actually think that it is possible. Right now, I am trying to figure it out but if you know the answer, please, share it with me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742748495



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       Yes, exactly the problem you describe in the steps above is what I meant. It has very little to do with the mailbox. It would be the same if the steps above were called outside of the mailbox. It is caused by closing the channel on `EndOfPartition`.
   
   Per finished input gates. Yes, we will ignore it for local channels. What about remote channels? What happens if you try to send an announcement on a closed channel? Moreover, why should we bother with gates that have finished? We should not perform any operations for them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e95e8ceeb1b8990e029358dac5731e50415c7383 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967) 
   * 3e52cba2fa74f9b38f80ff44adeca63102bad59c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e95e8ceeb1b8990e029358dac5731e50415c7383 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743604169



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -396,12 +396,18 @@ int getBuffersInUseCount() {
     @VisibleForTesting
     public void announceBufferSize(int newBufferSize) {
         for (InputChannel channel : channels) {
-            channel.announceBufferSize(newBufferSize);
+            if (!channel.isReleased()) {
+                channel.announceBufferSize(newBufferSize);
+            }
         }
     }
 
     @Override
     public void triggerDebloating() {
+        if (isFinished()) {

Review comment:
       How about?:
   ```
           if (isFinished() || closeFuture.isDone()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942) 
   * e95e8ceeb1b8990e029358dac5731e50415c7383 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743601715



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > But my current solution considers that it is impossible to call announceBufferSize and releaseAllResources in parallel
   
   Please confirm that this may happen only when cancelling or failing a task externally, because we `closeAllInputGates` from the `TaskCanceler` thread. I've looked into it and I think that:
   1. It's the same/similar for all of the methods. The cancellation may happen at any given time, so taking e.g. `RemoteInputChannel#resumeConsumption` as an example, the channel might be released after the `checkState` condition.
   2. It is rather unlikely to cause problems. It very much depends on timing.
   3. Even if we fail (either on the `checkState` or while sending messages to the channel (I believe it might happen. I don't know which _listener_ you had in mind) it should not matter much. We are failing anyway and this exception should be ignored. We are already in FAILED/CANCELLING state (see `Task:765-821`).
   
   Please let me know what you think.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -396,12 +396,18 @@ int getBuffersInUseCount() {
     @VisibleForTesting
     public void announceBufferSize(int newBufferSize) {
         for (InputChannel channel : channels) {
-            channel.announceBufferSize(newBufferSize);
+            if (!channel.isReleased()) {
+                channel.announceBufferSize(newBufferSize);
+            }
         }
     }
 
     @Override
     public void triggerDebloating() {
+        if (isFinished()) {

Review comment:
       How about?:
   ```
           if (isFinished() || closeFuture.isDone()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742701577



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       I am not entirely sure if the description here is correct, or better said if it is precise.
   
   I believe calling any of the methods from a mailbox thread is not the reason for the problem. Correct me if I am wrong, but I believe the problem is exactly the same as described in `LocalInputChannel:198-204`.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that
+        // announceBufferSize would be called after it.

Review comment:
       ```suggestion
           // if releaseAllResources was called from the mailbox thread it is possible that
           // announceBufferSize would be called after it.
   ```

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;

Review comment:
       I guess you can move that inside of the `if` block.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       BTW, don't we have a bigger problem, that we try to perform debloating even if a `SingleInputGate` might've finished already? What happens if we have two input gates and one of the gates finishes early (receives the end of partition), while the other processes records continuously? Could you try that out?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742742833



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       Maybe I don't fully understand the problem about finished `SingleInputGate`, but as I understand after this ticket we will just send nothing to already finished channels. So it should work totally fine. 
   Or is your question about how correctly can we calculate buffer size if some of the gates would be finished? ( I actually think it should also work especially after your ticket about multiply gates)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742895929



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > What happens if you try to send an announcement on a closed channel?
   As I see, it is not a problem for the remote channel because we remove the listener on releasing, and when we send something to the closed channel we just ignore it.(at least I see it in my brief test)

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > What happens if you try to send an announcement on a closed channel?
   
   As I see, it is not a problem for the remote channel because we remove the listener on releasing, and when we send something to the closed channel we just ignore it.(at least I see it in my brief test)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742749519



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;

Review comment:
       yes, I guess I can but in this case, I will need to double-check subpartitinView for null because if `releaseAllResources` and `announceBufferSize` will be called in parallel it will be a problem. I know that logically, it is impossible right now to execute these methods in parallel but anyway we don't have such explicit restrictions in the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742805295



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;

Review comment:
       Can you post the previous code again? I think you did it before anyway. Correct me if I am wrong, but didn't you do?:
   ```
   ResultSubpartitionView view = this.subpartitionView;
   if (!isRelease) {
      ResultSubpartitionView subpartitionView = checkNotNull(view);
      ...
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942) 
   * e95e8ceeb1b8990e029358dac5731e50415c7383 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26041",
       "triggerID" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3e52cba2fa74f9b38f80ff44adeca63102bad59c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   * 62f39de70a7c661eb2fe8062373d7c9a2eb46bcc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743613444



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > Please confirm that this may happen only when cancelling or failing a task externally,
   
   I confirm that in my opinion, it is the only place where it can happen.
   
   In general, I agree that it is the same situation as with other similar methods (like `RemoteInputChannel#resumeConsumption`) and I agree that it should not matter much because it means that job is  already failing. So perhaps, my last changes should work fine.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > Please confirm that this may happen only when cancelling or failing a task externally,
   
   I confirm that in my opinion, it is the only place where it can happen.
   
   In general, I agree that it is the same situation as with other similar methods (like `RemoteInputChannel#resumeConsumption`) and I agree that it should not matter much because it means that job is  already failing. So perhaps, my last changes should work fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742739855



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       The key problem here is following:
   
   - The mailbox takes EndOfPartitionEvent for handling
   - At the same time, timerService submit buffer debloater to the mailbox
   - The mailbox release all resources for the channel because of EndOfPartitionEvent
   - the mailbox submit suspend mailbox task to mailbox because all channels  were ended
   - The mailbox takes the next task which is buffer debloater and we have the problem describing in this task




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959550042


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7310e043a821d9bb5a58597566284d98df6988cc (Wed Nov 03 15:58:49 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24738).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743601715



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > But my current solution considers that it is impossible to call announceBufferSize and releaseAllResources in parallel
   
   Please confirm that this may happen only when cancelling or failing a task externally, because we `closeAllInputGates` from the `TaskCanceler` thread. I've looked into it and I think that:
   1. It's the same/similar for all of the methods. The cancellation may happen at any given time, so taking e.g. `RemoteInputChannel#resumeConsumption` as an example, the channel might be released after the `checkState` condition.
   2. It is rather unlikely to cause problems. It very much depends on timing.
   3. Even if we fail (either on the `checkState` or while sending messages to the channel (I believe it might happen. I don't know which _listener_ you had in mind) it should not matter much. We are failing anyway and this exception should be ignored. We are already in FAILED/CANCELLING state (see `Task:765-821`).
   
   Please let me know what you think.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -396,12 +396,18 @@ int getBuffersInUseCount() {
     @VisibleForTesting
     public void announceBufferSize(int newBufferSize) {
         for (InputChannel channel : channels) {
-            channel.announceBufferSize(newBufferSize);
+            if (!channel.isReleased()) {
+                channel.announceBufferSize(newBufferSize);
+            }
         }
     }
 
     @Override
     public void triggerDebloating() {
+        if (isFinished()) {

Review comment:
       How about?:
   ```
           if (isFinished() || closeFuture.isDone()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] akalash commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743613444



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > Please confirm that this may happen only when cancelling or failing a task externally,
   
   I confirm that in my opinion, it is the only place where it can happen.
   
   In general, I agree that it is the same situation as with other similar methods (like `RemoteInputChannel#resumeConsumption`) and I agree that it should not matter much because it means that job is  already failing. So perhaps, my last changes should work fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r743601715



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       > But my current solution considers that it is impossible to call announceBufferSize and releaseAllResources in parallel
   
   Please confirm that this may happen only when cancelling or failing a task externally, because we `closeAllInputGates` from the `TaskCanceler` thread. I've looked into it and I think that:
   1. It's the same/similar for all of the methods. The cancellation may happen at any given time, so taking e.g. `RemoteInputChannel#resumeConsumption` as an example, the channel might be released after the `checkState` condition.
   2. It is rather unlikely to cause problems. It very much depends on timing.
   3. Even if we fail (either on the `checkState` or while sending messages to the channel (I believe it might happen. I don't know which _listener_ you had in mind) it should not matter much. We are failing anyway and this exception should be ignored. We are already in FAILED/CANCELLING state (see `Task:765-821`).
   
   Please let me know what you think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 7310e043a821d9bb5a58597566284d98df6988cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742748495



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
 
     @Override
     void announceBufferSize(int newBufferSize) {
-        checkState(!isReleased, "Channel released.");
-
-        ResultSubpartitionView subpartitionView = checkNotNull(this.subpartitionView);
-        subpartitionView.notifyNewBufferSize(newBufferSize);
+        ResultSubpartitionView view = this.subpartitionView;
+        // if releaseAllResources would be called from the mailbox thread it is possible that

Review comment:
       Yes, exactly the problem you describe in the steps above is what I meant. It has very little to do with the mailbox. It would be the same if the steps above were called outside of the mailbox. It is a problem of closing the channel on `EndOfPartition`.
   
   Per finished input gates. Yes, we will ignore it for local channels. What about remote channels? What happens if you try to send an announcement on a closed channel? Moreover, why should we bother with gates that have finished? We should not perform any operations for them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17663:
URL: https://github.com/apache/flink/pull/17663#issuecomment-959548410


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7310e043a821d9bb5a58597566284d98df6988cc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25890",
       "triggerID" : "960611012",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25942",
       "triggerID" : "62f39de70a7c661eb2fe8062373d7c9a2eb46bcc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967",
       "triggerID" : "e95e8ceeb1b8990e029358dac5731e50415c7383",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26041",
       "triggerID" : "3e52cba2fa74f9b38f80ff44adeca63102bad59c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e95e8ceeb1b8990e029358dac5731e50415c7383 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25967) 
   * 3e52cba2fa74f9b38f80ff44adeca63102bad59c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys merged pull request #17663: [FLINK-24738][runtime] Ignoring buffer size announcement if the channel is released already

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #17663:
URL: https://github.com/apache/flink/pull/17663


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org