You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2025/11/30 09:51:40 UTC

[GH] (shardingsphere/fix/oracle-timestamp-with-timezone-order-by): Workflow run "E2E - Agent" failed!

The GitHub Actions job "E2E - Agent" on shardingsphere.git/fix/oracle-timestamp-with-timezone-order-by has failed.
Run started by GitHub user zhan7236 (triggered by zhan7236).

Head commit for run:
9a55b0f9a4e48c5984693e23882a760bce2dc173 / zhan7236 <76...@users.noreply.github.com>
refactor: rename getTimestampValue to getDefaultValue and fix default behavior

Address review feedback from maintainer @terrymanu:
- Renamed getTimestampValue() to getDefaultValue() to better reflect its purpose
- Changed default implementation from getTimestamp() to getObject() to preserve
  backward compatibility for non-timestamp types (JSON, UUID, BIT, etc.)
- Oracle's vendor-specific type codes (-101/-102) are now handled solely inside
  OracleResultSetMapper, preventing unintended side effects for other dialects

This ensures:
1. Only Oracle TIMESTAMP WITH TIME ZONE types are specially handled
2. All other unhandled types continue to use getObject() as before
3. No compatibility issues for MySQL/PostgreSQL/openGauss dialects

Report URL: https://github.com/apache/shardingsphere/actions/runs/19797153638

With regards,
GitHub Actions via GitBox