You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/29 12:00:57 UTC
[GitHub] [camel-k] oscerd opened a new pull request #2790: Fix doc port name
oscerd opened a new pull request #2790:
URL: https://github.com/apache/camel-k/pull/2790
Fixes #2761
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a change in pull request #2790: Fix doc port name
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #2790:
URL: https://github.com/apache/camel-k/pull/2790#discussion_r758304111
##########
File path: pkg/trait/container.go
##########
@@ -68,7 +68,7 @@ type containerTrait struct {
Expose *bool `property:"expose" json:"expose,omitempty"`
// To configure a different port exposed by the container (default `8080`).
Port int `property:"port" json:"port,omitempty"`
- // To configure a different port name for the port exposed by the container (default `http`).
+ // To configure a different port name for the port exposed by the container. it defaults to `http` only when the `expose` parameter is true.
Review comment:
should be fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a change in pull request #2790: Fix doc port name
Posted by GitBox <gi...@apache.org>.
squakez commented on a change in pull request #2790:
URL: https://github.com/apache/camel-k/pull/2790#discussion_r758299429
##########
File path: pkg/trait/container.go
##########
@@ -68,7 +68,7 @@ type containerTrait struct {
Expose *bool `property:"expose" json:"expose,omitempty"`
// To configure a different port exposed by the container (default `8080`).
Port int `property:"port" json:"port,omitempty"`
- // To configure a different port name for the port exposed by the container (default `http`).
+ // To configure a different port name for the port exposed by the container. it defaults to `http` only when the `expose` parameter is true.
Review comment:
Maybe uppercase here. "It defaults ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd merged pull request #2790: Fix doc port name
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #2790:
URL: https://github.com/apache/camel-k/pull/2790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org