[GitHub] [incubator-linkis] peacewong commented on pull request #1829: Script custom variable run type and suffix constraint configuration.

[GitBox <gi...@apache.org>]

peacewong commented on pull request #1829:
URL: https://github.com/apache/incubator-linkis/pull/1829#issuecomment-1082698283


   Thanks.
   Question 1: This is reasonable, but I think the CodeTypeAndRunTypeRelationMap should be made a singleton instead of regenerating every time.
   问题1：这个是合理的，但是我认为应该将CodeTypeAndRunTypeRelationMap作为单例，而不是每次都重新生成
   
   Question 2 seems to be a bug, it should be classified as a python class or defined as a shell class, because their comments all start with "#", not the "--" of sql
   问题2这个看是Bug，应该归类为python类或者定义为shell类，因为他们的注释都是“#”开头，而不是sql的“--”开头
   
   Question 3 CustomVariableUtils in the orchestrator module will be removed, the code is being merged
   问题3  orchestrator模块中的CustomVariableUtils将会被移除掉，正在合并代码
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org