[GitHub] [activemq-nms-openwire] killnine opened a new pull request #9: [AMQNET-565] - .net standard conversion, project reorganization

[GitBox <gi...@apache.org>]

killnine opened a new pull request #9: [AMQNET-565] - .net standard conversion, project reorganization
URL: https://github.com/apache/activemq-nms-openwire/pull/9
 
 
   **Background:**
   The following PR is related to the two existing JIRA issues [AMQNET-565](https://issues.apache.org/jira/browse/AMQNET-565) and [AMQNET-588](https://issues.apache.org/jira/browse/AMQNET-588) to clean up AMQ NMS and update it to support .net standard 2.0. 
   
   **Change Summary:**
   
   - Created new solution file compatible with VS2019
   - Created three new, sepearate projects to house the main binaries (.net standard 2.0), test binaries (.net core 2.2), and documentation (.net standard)
   - Replaced Sandcastle documentation with [DocFx](https://dotnet.github.io/docfx/), as 
   - Updated build script to follow [AMQ NMS API](https://github.com/apache/activemq-nms-api/blob/master/package.ps1)'s example
   - Updated to NUnit3 and made minor unit test changes to replace deprecated functionality
   - Removed incompatible reference, Ionic.ZLib, and replaced with first-party compression solution
   - Updated README and added RELEASE documents according to AMQ NMS API's example
   
   **Areas to Focus:**
   
   - I'm struggling to get unit testing running against a local test broker. So if someone can test that out as well, I'd appreciate it greatly.
   - The package.ps1 script doesn't seem to be working but I'm not familiar enough with what it should be doing to debug that much
   - RELEASE.md probably needs some clarification. This must be for how the package is released to Apache but I just don't understand it.
   - I will try and call out any code change areas below so it's clear when I do more than just 'convert'.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services