You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2012/07/17 00:08:33 UTC
[jira] [Created] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Henry Saputra created SHINDIG-1817:
--------------------------------------
Summary: Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
Key: SHINDIG-1817
URL: https://issues.apache.org/jira/browse/SHINDIG-1817
Project: Shindig
Issue Type: Bug
Components: Javascript
Affects Versions: 2.5.0-beta2
Reporter: Henry Saputra
Fix For: 2.5.0-beta3
The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
Example gadget:
<Module>
<ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
<Require feature="dynamic-height" />
<Require feature="dynamic-width" />
</ModulePrefs>
<Content type="html" view="default"><![CDATA[
<head>
<style type="text/css">
body {
padding-bottom: 50px;
}
#wrap {
height:100%
},
#main {
padding-bottom: 100px;
},
#footer {
position: fixed;
height: 50px;
clear:both;
left: 0;
bottom: 0;
}
</style>
<script type="text/javascript">
gadgets.util.registerOnLoadHandler(function() {
gadgets.window.adjustHeight();
// setting interval for calling gadgets.window.adjustHeight, this shouldnt
// cause the gadget to forever increase in height.
window.setInterval(gadgets.window.adjustHeight, 5000);
});
</script>
</head>
<body id="mainbody">
<div id="wrap">
<div id="main">
Main canvas content.
</div>
<div id="footer">
Footer element.
</div>
</div>
</body>
]]></Content>
</Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415817#comment-13415817 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
Seems like it has to do with combo of padding-bottom style of the body and fixed element assigned at the left bottom of the window.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416641#comment-13416641 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
Hi Dan, I was actually saying the same thing as Ryan =)
Basically we should not change the behavior of current dynamic height resize behavior right bc its too close to release.
Yeah, precisely, the question is whether we want to support/ fix this kind of layout for a gadget.
We should not assume gadget wont call auto-size in an interval.
Maybe we could ignore all elements that has position other than static when calculating the height bc those elements could be anywhere in the page.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417049#comment-13417049 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
Does that make sense? Perhaps we can get together on irc/gtalk/confcall to talk it over?
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417221#comment-13417221 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
I agree the algorithm to accurately calculate the true height is complicated. I am ok updating this either with wont fix or not an issue.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417043#comment-13417043 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
I'm not talking about changing the impl or spec at this time.
What I mean is that the spec states: "If not specified, will attempt to fit the gadget to its content"
I'm trying to say that the "will attempt" is a queue to the gadget developer that this is a best-effort scenario. Containers can and should determine if they even want to support this, or place limits on it.
Anyway, a gadget growing out of control sounds like a container issue to me (even though technically the gadget feature code is doing it) you could accomplish the same thing by calling adjust height and passing an incremented number on a timer.
What I'm trying to say is this:
* Auto sizing is difficult, and I don't think we should try to find a bulletproof scenario because gadget developers already know how much space they want/need. I'd rather suggest to them that they they use the auto-sizing feature sparingly.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416585#comment-13416585 ]
Ryan Baxter commented on SHINDIG-1817:
--------------------------------------
Dan I don't think we can make such a change while closing down 2.5 (mainly from a spec perspective).
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra reassigned SHINDIG-1817:
--------------------------------------
Assignee: Dan Dumont
Dan, I assigned this to you. Let me know if its not ok with you.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416567#comment-13416567 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
We could add new API to resize to whatever real-estate container given but I would like to keep dynamic height to resize max to accomodate all elements in the gadget.
I think we could exclude other CSS positions that are not static because it could jump all over place.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416199#comment-13416199 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
With the new changes to gadget scrolling, I'd like to de-emphasize (possibly even deprecate) the no param adjust call (auto-fit).
I'd like to take more of an approach that gadgets must try to use whatever real-estate they are given (very similar to what you would do in mobile development where you must fit many different but similar form factors). Gadgets can optionally request more size, but the container needs to provide limits on how large/small they can grow or shrink.
What do you think?
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416604#comment-13416604 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
Ryan, understood. Wan't talking about making a change, just wanted to discourage the use of the auto-size feature of dynamic size... it was always presented as a "best effort" (or at least should have been)
Henry, not sure what you're saying.
The current api will take a height/width value and use that when talking with the container. The current container impl always gives the gadget what it asks for, but that's not the recommended implementation for most containers to use. Many containers will want to base that information on the specifics of where the re-sizing gadget site is located and how much room they are allowed to have.
I think your example is always pushing the document size out of the current iframe size due to static positioning and margins... repeated calls to the autosize api will cause it to grow forever and I don't think that's an issue... i would expect that to happen I think. But I would actually expect for gadgets to use the auto-size sparingly, certainly not in a loop.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418510#comment-13418510 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
Sounds good.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SHINDIG-1817) Dynamic height algortihm
fail to recognize elements with CSS position fixed and absolute to make it
forever increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416206#comment-13416206 ]
Dan Dumont edited comment on SHINDIG-1817 at 7/17/12 1:59 PM:
--------------------------------------------------------------
I guess my thought flow is that, a gadget can inspect how much space it's given and lay itself out accordingly... it can then request its ideal size, and maybe get it.
was (Author: ddumont):
I guess my though flow is that, a gadget can inspect how much space it's given and lay itself out accordingly... it can then request its ideal size, and maybe get it.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415707#comment-13415707 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
The example gadget above basically add padding-bottom to the body such that the position fixed footer is always put in the bottom of the page
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418500#comment-13418500 ]
Henry Saputra commented on SHINDIG-1817:
----------------------------------------
Lets put wont fix.
Because it is actually an issue but should/could be handled by the gadget developer by modifying the layout and/ or client code for resizing.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416206#comment-13416206 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
I guess my though flow is that, a gadget can inspect how much space it's given and lay itself out accordingly... it can then request its ideal size, and maybe get it.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417252#comment-13417252 ]
Dan Dumont commented on SHINDIG-1817:
-------------------------------------
Which would you prefer? :)
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SHINDIG-1817) Dynamic height algortihm
fail to recognize elements with CSS position fixed and absolute to make it
forever increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416206#comment-13416206 ]
Dan Dumont edited comment on SHINDIG-1817 at 7/17/12 2:00 PM:
--------------------------------------------------------------
I guess my thought flow is that a gadget can inspect how much space it's given and lay itself out accordingly... it can then request its ideal size, and maybe get it.
was (Author: ddumont):
I guess my thought flow is that, a gadget can inspect how much space it's given and lay itself out accordingly... it can then request its ideal size, and maybe get it.
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1817) Dynamic height algortihm fail to
recognize elements with CSS position fixed and absolute to make it forever
increasing in height
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1817.
---------------------------------
Resolution: Won't Fix
> Dynamic height algortihm fail to recognize elements with CSS position fixed and absolute to make it forever increasing in height
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1817
> URL: https://issues.apache.org/jira/browse/SHINDIG-1817
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta2
> Reporter: Henry Saputra
> Assignee: Dan Dumont
> Labels: dynamic_height, javascript
> Fix For: 2.5.0-beta3
>
>
> The new algorithm to calculate dynamic height does not consider elements with position fixed and absolute that are not part of the static flows which could cause forever increase in height.
> Example gadget:
> <Module>
> <ModulePrefs title="Dynamic Height Size example with fixed position element test gadget">
> <Require feature="dynamic-height" />
> <Require feature="dynamic-width" />
> </ModulePrefs>
> <Content type="html" view="default"><![CDATA[
> <head>
> <style type="text/css">
> body {
> padding-bottom: 50px;
> }
> #wrap {
> height:100%
> },
> #main {
> padding-bottom: 100px;
> },
> #footer {
> position: fixed;
> height: 50px;
> clear:both;
> left: 0;
> bottom: 0;
> }
> </style>
> <script type="text/javascript">
> gadgets.util.registerOnLoadHandler(function() {
> gadgets.window.adjustHeight();
> // setting interval for calling gadgets.window.adjustHeight, this shouldnt
> // cause the gadget to forever increase in height.
> window.setInterval(gadgets.window.adjustHeight, 5000);
> });
> </script>
> </head>
> <body id="mainbody">
> <div id="wrap">
> <div id="main">
> Main canvas content.
> </div>
> <div id="footer">
> Footer element.
> </div>
> </div>
> </body>
> ]]></Content>
> </Module>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira