You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/10 19:21:23 UTC
Review Request 31904: Fixed comparison of protobufs with optional
fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31904/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Joerg Schad.
Bugs: MESOS-2309
https://issues.apache.org/jira/browse/MESOS-2309
Repository: mesos
Description
-------
Now optional fields are compared in the same way as required fields.
I changed the order of fields to match the tag numbers for consistency.
Diffs
-----
src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3
Diff: https://reviews.apache.org/r/31904/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 31904: Fixed comparison of protobufs with optional
fields.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31904/#review76082
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 6:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31904/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 6:21 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Joerg Schad.
>
>
> Bugs: MESOS-2309
> https://issues.apache.org/jira/browse/MESOS-2309
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now optional fields are compared in the same way as required fields.
>
> I changed the order of fields to match the tag numbers for consistency.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3
>
> Diff: https://reviews.apache.org/r/31904/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>