You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/22 04:55:24 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1436: Minor fix in CPP and ARCHCFLAGS arguments from PR #1426

xiaoxiang781216 commented on a change in pull request #1436:
URL: https://github.com/apache/incubator-nuttx/pull/1436#discussion_r458533632



##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -92,7 +92,7 @@ endif
 
 CC = $(CROSSDEV)gcc
 CXX = $(CROSSDEV)g++
-CPP = $(CROSSDEV)gcc -E
+CPP = $(CROSSDEV)gcc -E -P -x c

Review comment:
       Since C preprocessor is same as C++ preprocessor, so I think both will be fine. But -x option is important if we want preprocess some non C/C++ file(e.g. link script or bash script).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org