[jira] [Commented] (MAPREDUCE-6575) TestMRJobs.setup() should use YarnConfiguration properties instead of bare strings

["Neelesh Srinivas Salian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060804#comment-15060804 ] 

Neelesh Srinivas Salian commented on MAPREDUCE-6575:
----------------------------------------------------

Hi [~templedf]

Are there other fields in methods/files that could use this change?
This makes sense only in cases (as you pointed out) as long as the values are static/default.
Maybe good to broaden this to other file(s) if needed.



> TestMRJobs.setup() should use YarnConfiguration properties instead of bare strings
> ----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6575
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6575
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>
> MAPREDUCE-5870 introduced the following line:
> {code}
>       conf.setInt("yarn.cluster.max-application-priority", 10);
> {code}
> It should instead be:
> {code}
>       conf.setInt(YarnConfiguration.MAX_CLUSTER_LEVEL_APPLICATION_PRIORITY, 10);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)