You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/05 08:00:19 UTC
[GitHub] [servicecomb-service-center] humingcheng opened a new pull request
#629: [SCB-1742] Use cache only when Indexer is not creditable
humingcheng opened a new pull request #629: [SCB-1742] Use cache only when Indexer is not creditable
URL: https://github.com/apache/servicecomb-service-center/pull/629
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls edited a comment on issue
#629: [SCB-1742] Use cache only when Indexer is not creditable
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #629: [SCB-1742] Use cache only when Indexer is not creditable
URL: https://github.com/apache/servicecomb-service-center/pull/629#issuecomment-582388916
[](https://coveralls.io/builds/28567346)
Coverage decreased (-0.08%) to 59.603% when pulling **f341f77f79acbfbb66abc0ad431881f54ceb5ae3 on humingcheng:discoveryCache** into **85dc71bdc30cb3a226170b99c98e8e3df6cc5c78 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request
#629: [SCB-1742] Use cache only when Indexer is not creditable
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #629: [SCB-1742] Use cache only when Indexer is not creditable
URL: https://github.com/apache/servicecomb-service-center/pull/629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #629:
[SCB-1742] Use cache only when Indexer is not creditable
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #629: [SCB-1742] Use cache only when Indexer is not creditable
URL: https://github.com/apache/servicecomb-service-center/pull/629#issuecomment-582388916
[](https://coveralls.io/builds/28542171)
Coverage decreased (-0.03%) to 59.653% when pulling **a306da1633360580882d987e624694fc75a47e35 on humingcheng:discoveryCache** into **85dc71bdc30cb3a226170b99c98e8e3df6cc5c78 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #629:
[SCB-1742] Use cache only when Indexer is not creditable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #629: [SCB-1742] Use cache only when Indexer is not creditable
URL: https://github.com/apache/servicecomb-service-center/pull/629#issuecomment-582388953
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=h1) Report
> Merging [#629](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 57.12% 57.16% +0.04%
==========================================
Files 207 207
Lines 16062 16068 +6
==========================================
+ Hits 9175 9185 +10
+ Misses 6220 6219 -1
+ Partials 667 664 -3
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `93.75% <0%> (-6.25%)` | :arrow_down: |
| [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `94.11% <0%> (-5.89%)` | :arrow_down: |
| [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `78.94% <0%> (-9.29%)` | :arrow_down: |
| [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `41.79% <0%> (+0.61%)` | :arrow_up: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `63.1% <0%> (-0.98%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `69.14% <0%> (-0.38%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
| [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `73.8% <0%> (+2.38%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/629/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=footer). Last update [85dc71b...a306da1](https://codecov.io/gh/apache/servicecomb-service-center/pull/629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services