You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/12 06:41:29 UTC
[GitHub] [apisix] moonming opened a new pull request #3815: doc: make the document easier to read about upstream host.
moonming opened a new pull request #3815:
URL: https://github.com/apache/apisix/pull/3815
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3815: doc: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273544
@juzhiyuan please update the dashboard repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3815: docs: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#discussion_r593054000
##########
File path: docs/en/latest/admin-api.md
##########
@@ -23,15 +23,15 @@ title: Admin API
## Table of Contents
-* [Route](#route)
-* [Service](#service)
-* [Consumer](#consumer)
-* [Upstream](#upstream)
-* [SSL](#ssl)
-* [Global Rule](#global-rule)
-* [Plugin Config](#plugin-config)
-* [Plugin Metadata](#plugin-metadata)
-* [Plugin](#plugin)
+- [Route](#route)
+- [Service](#service)
+- [Consumer](#consumer)
+- [Upstream](#upstream)
+- [SSL](#ssl)
+- [Global Rule](#global-rule)
+- [Plugin config](#plugin-config)
Review comment:
Why we need to use lowercase here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #3815: docs: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #3815:
URL: https://github.com/apache/apisix/pull/3815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3815: docs: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#discussion_r593031207
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -23,7 +23,7 @@ title: Admin API
## 目录
-- [目录](#目录)
+- [目录](#%e7%9b%ae%e5%bd%95)
Review comment:
thanks
##########
File path: docs/en/latest/admin-api.md
##########
@@ -547,11 +547,11 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst
`hash_on` can be set to different types:
1. when it is `vars`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html), without the prefix '$'.
-1. when it is `header`, the `key` is required. It is equal to "http_`key`".
-1. when it is `cookie`, the `key` is required. It is equal to "cookie_`key`".
-1. when it is `consumer`, the `key` is optional. The key is the `consumer_name` set by authentication plugin.
-1. when it is `vars_combinations`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html) combinations, such as `$request_uri$remote_addr`.
-1. If there is no value for either `hash_on` or `key`, `remote_addr` will be used as key.
+2. when it is `header`, the `key` is required. It is equal to "http_`key`".
Review comment:
yes, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3815: doc: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#discussion_r592967287
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -23,7 +23,7 @@ title: Admin API
## 目录
-- [目录](#目录)
+- [目录](#%e7%9b%ae%e5%bd%95)
Review comment:
Please keep the original name
##########
File path: docs/en/latest/admin-api.md
##########
@@ -547,11 +547,11 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst
`hash_on` can be set to different types:
1. when it is `vars`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html), without the prefix '$'.
-1. when it is `header`, the `key` is required. It is equal to "http_`key`".
-1. when it is `cookie`, the `key` is required. It is equal to "cookie_`key`".
-1. when it is `consumer`, the `key` is optional. The key is the `consumer_name` set by authentication plugin.
-1. when it is `vars_combinations`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html) combinations, such as `$request_uri$remote_addr`.
-1. If there is no value for either `hash_on` or `key`, `remote_addr` will be used as key.
+2. when it is `header`, the `key` is required. It is equal to "http_`key`".
Review comment:
We don't need to change this. Markdown will handle the order automatically. There is no need to maintain the order by us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3815: doc: make the document easier to read about upstream host.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273854
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org