[GitHub] [tvm] driazati commented on a change in pull request #10057: Add @slow decorator to run tests on `main`

[GitBox <gi...@apache.org>]

driazati commented on a change in pull request #10057:
URL: https://github.com/apache/tvm/pull/10057#discussion_r793928940



##########
File path: python/tvm/testing/utils.py
##########
@@ -84,6 +84,8 @@ def test_something():
 from tvm.relay.op.contrib.ethosn import ethosn_available
 from tvm.relay.op.contrib import cmsisnn
 
+SKIP_SLOW_TESTS = os.getenv("SKIP_SLOW_TESTS", "").lower() in {"true", "1", "yes"}

Review comment:
       same as for the slow test triggers below, unlike skip ci where that was almost intentionally hard to use, this is something "user-facing" so it should accept all reasonable input (i.e. remembering that it has to be `1` instead of `yes` when tools like cmake accept either is confusing for no reason). Same for triggering slow tests, if someone's intent is clear but they don't remember the exact magic words we should still run the tests. 

##########
File path: tests/scripts/should_run_slow_tests.py
##########
@@ -0,0 +1,144 @@
+#!/usr/bin/env python3
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+import json
+import argparse
+import subprocess
+import re
+import textwrap
+from urllib import request
+from typing import Dict, Tuple, Any, List, Optional
+
+SLOW_TEST_TRIGGERS = [

Review comment:
       see comment above
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org