You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Tzu-ping Chung <tp...@astronomer.io.INVALID> on 2022/08/16 23:32:40 UTC
User Kinceo1 posting spam review approvals
Hi all,
Recently the user Kinceo1 on GitHub has been posting review approvals in a ton of PRs. Those reviews all contain one single emoji, and are done arbitrarily since multiple of those PRs are very obviously not in reviewable shape with significant errors. These spams are quite annoying and mess up my notification timeline.
Would it be possible to do anything about this? If I recall correctly, GitHub only allows blocking a user from commenting based on organisation, so this might only be doable if we post a request to Apache? Are there other options to stop the spamming?
TP
Re: User Kinceo1 posting spam review approvals
Posted by "Ferruzzi, Dennis" <fe...@amazon.com.INVALID>.
I do love it when a problem solves itself..
________________________________
From: Tzu-ping Chung <tp...@astronomer.io.INVALID>
Sent: Friday, August 19, 2022 8:28 PM
To: dev@airflow.apache.org
Subject: RE: [EXTERNAL]User Kinceo1 posting spam review approvals
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Forgot to update here—GitHub has since invalidated the user service-wide so this is no longer an issue.
On 18 Aug 2022, at 03:21, Kaxil Naik <ka...@gmail.com>> wrote:
Yeah, I agree about creating an INFRA ticket too
On Wed, 17 Aug 2022 at 10:31, Jarek Potiuk <ja...@potiuk.com>> wrote:
Yeah. I noticed that too and agree we should block the user. And I think with the three voices agreeing here, this is the right thing to do - unless someone objects.
The Infra ticket is the only way (and all committers can do it :). Good exercise for you TP to start interfacing with INFRA :).
Happy to help and chime in if needed.
And Yes. I also freeze and the rest of my hair stands up when I hear the "JIRA" word, but it's not that bad and they are usually pretty responsive if we provide context and information that we generally agree as PMC we should do it.
J.
On Wed, Aug 17, 2022 at 9:42 AM Ash Berlin-Taylor <as...@apache.org>> wrote:
We'll need to open a jira ticket in the INFRA queue similar to https://issues.apache.org/jira/browse/INFRA-20838 (As a commiter you can log in to that Jira instance with your asf credentials I think)
Link to all their interactions which is probably useful to include https://github.com/apache/airflow/issues?q=commenter%3AKinceo1
-ash
On Wed, Aug 17 2022 at 07:32:40 +08:00:00, Tzu-ping Chung <tp...@astronomer.io.INVALID>> wrote:
Hi all, Recently the user Kinceo1 on GitHub has been posting review approvals in a ton of PRs. Those reviews all contain one single emoji, and are done arbitrarily since multiple of those PRs are very obviously not in reviewable shape with significant errors. These spams are quite annoying and mess up my notification timeline. Would it be possible to do anything about this? If I recall correctly, GitHub only allows blocking a user from commenting based on organisation, so this might only be doable if we post a request to Apache? Are there other options to stop the spamming? TP
Re: User Kinceo1 posting spam review approvals
Posted by Tzu-ping Chung <tp...@astronomer.io.INVALID>.
Forgot to update here—GitHub has since invalidated the user service-wide so this is no longer an issue.
> On 18 Aug 2022, at 03:21, Kaxil Naik <ka...@gmail.com> wrote:
>
> Yeah, I agree about creating an INFRA ticket too
>
> On Wed, 17 Aug 2022 at 10:31, Jarek Potiuk <jarek@potiuk.com <ma...@potiuk.com>> wrote:
> Yeah. I noticed that too and agree we should block the user. And I think with the three voices agreeing here, this is the right thing to do - unless someone objects.
>
> The Infra ticket is the only way (and all committers can do it :). Good exercise for you TP to start interfacing with INFRA :).
> Happy to help and chime in if needed.
>
> And Yes. I also freeze and the rest of my hair stands up when I hear the "JIRA" word, but it's not that bad and they are usually pretty responsive if we provide context and information that we generally agree as PMC we should do it.
>
> J.
>
> On Wed, Aug 17, 2022 at 9:42 AM Ash Berlin-Taylor <ash@apache.org <ma...@apache.org>> wrote:
> We'll need to open a jira ticket in the INFRA queue similar to https://issues.apache.org/jira/browse/INFRA-20838 <https://issues.apache.org/jira/browse/INFRA-20838> (As a commiter you can log in to that Jira instance with your asf credentials I think)
>
> Link to all their interactions which is probably useful to include https://github.com/apache/airflow/issues?q=commenter%3AKinceo1 <https://github.com/apache/airflow/issues?q=commenter%3AKinceo1>
>
> -ash
>
> On Wed, Aug 17 2022 at 07:32:40 +08:00:00, Tzu-ping Chung <tp...@astronomer.io.INVALID> wrote:
>> Hi all,
>>
>> Recently the user Kinceo1 on GitHub has been posting review approvals in a ton of PRs. Those reviews all contain one single emoji, and are done arbitrarily since multiple of those PRs are very obviously not in reviewable shape with significant errors. These spams are quite annoying and mess up my notification timeline.
>>
>> Would it be possible to do anything about this? If I recall correctly, GitHub only allows blocking a user from commenting based on organisation, so this might only be doable if we post a request to Apache? Are there other options to stop the spamming?
>>
>> TP
Re: User Kinceo1 posting spam review approvals
Posted by Kaxil Naik <ka...@gmail.com>.
Yeah, I agree about creating an INFRA ticket too
On Wed, 17 Aug 2022 at 10:31, Jarek Potiuk <ja...@potiuk.com> wrote:
> Yeah. I noticed that too and agree we should block the user. And I think
> with the three voices agreeing here, this is the right thing to do - unless
> someone objects.
>
> The Infra ticket is the only way (and all committers can do it :). Good
> exercise for you TP to start interfacing with INFRA :).
> Happy to help and chime in if needed.
>
> And Yes. I also freeze and the rest of my hair stands up when I hear the
> "JIRA" word, but it's not that bad and they are usually pretty responsive
> if we provide context and information that we generally agree as PMC we
> should do it.
>
> J.
>
> On Wed, Aug 17, 2022 at 9:42 AM Ash Berlin-Taylor <as...@apache.org> wrote:
>
>> We'll need to open a jira ticket in the INFRA queue similar to
>> https://issues.apache.org/jira/browse/INFRA-20838 (As a commiter you can
>> log in to that Jira instance with your asf credentials I think)
>>
>> Link to all their interactions which is probably useful to include
>> https://github.com/apache/airflow/issues?q=commenter%3AKinceo1
>>
>> -ash
>>
>> On Wed, Aug 17 2022 at 07:32:40 +08:00:00, Tzu-ping Chung
>> <tp...@astronomer.io.INVALID> wrote:
>>
>> Hi all, Recently the user Kinceo1 on GitHub has been posting review
>> approvals in a ton of PRs. Those reviews all contain one single emoji, and
>> are done arbitrarily since multiple of those PRs are very obviously not in
>> reviewable shape with significant errors. These spams are quite annoying
>> and mess up my notification timeline. Would it be possible to do anything
>> about this? If I recall correctly, GitHub only allows blocking a user from
>> commenting based on organisation, so this might only be doable if we post a
>> request to Apache? Are there other options to stop the spamming? TP
>>
>>
Re: User Kinceo1 posting spam review approvals
Posted by Jarek Potiuk <ja...@potiuk.com>.
Yeah. I noticed that too and agree we should block the user. And I think
with the three voices agreeing here, this is the right thing to do - unless
someone objects.
The Infra ticket is the only way (and all committers can do it :). Good
exercise for you TP to start interfacing with INFRA :).
Happy to help and chime in if needed.
And Yes. I also freeze and the rest of my hair stands up when I hear the
"JIRA" word, but it's not that bad and they are usually pretty responsive
if we provide context and information that we generally agree as PMC we
should do it.
J.
On Wed, Aug 17, 2022 at 9:42 AM Ash Berlin-Taylor <as...@apache.org> wrote:
> We'll need to open a jira ticket in the INFRA queue similar to
> https://issues.apache.org/jira/browse/INFRA-20838 (As a commiter you can
> log in to that Jira instance with your asf credentials I think)
>
> Link to all their interactions which is probably useful to include
> https://github.com/apache/airflow/issues?q=commenter%3AKinceo1
>
> -ash
>
> On Wed, Aug 17 2022 at 07:32:40 +08:00:00, Tzu-ping Chung
> <tp...@astronomer.io.INVALID> wrote:
>
> Hi all, Recently the user Kinceo1 on GitHub has been posting review
> approvals in a ton of PRs. Those reviews all contain one single emoji, and
> are done arbitrarily since multiple of those PRs are very obviously not in
> reviewable shape with significant errors. These spams are quite annoying
> and mess up my notification timeline. Would it be possible to do anything
> about this? If I recall correctly, GitHub only allows blocking a user from
> commenting based on organisation, so this might only be doable if we post a
> request to Apache? Are there other options to stop the spamming? TP
>
>
Re: User Kinceo1 posting spam review approvals
Posted by Ash Berlin-Taylor <as...@apache.org>.
We'll need to open a jira ticket in the INFRA queue similar to
<https://issues.apache.org/jira/browse/INFRA-20838> (As a commiter you
can log in to that Jira instance with your asf credentials I think)
Link to all their interactions which is probably useful to include
<https://github.com/apache/airflow/issues?q=commenter%3AKinceo1>
-ash
On Wed, Aug 17 2022 at 07:32:40 +08:00:00, Tzu-ping Chung
<tp...@astronomer.io.INVALID> wrote:
> Hi all,
>
> Recently the user Kinceo1 on GitHub has been posting review approvals
> in a ton of PRs. Those reviews all contain one single emoji, and are
> done arbitrarily since multiple of those PRs are very obviously not
> in reviewable shape with significant errors. These spams are quite
> annoying and mess up my notification timeline.
>
> Would it be possible to do anything about this? If I recall
> correctly, GitHub only allows blocking a user from commenting based
> on organisation, so this might only be doable if we post a request to
> Apache? Are there other options to stop the spamming?
>
> TP