[GitHub] [camel-k] lfabriko commented on a diff in pull request #4245: Add Kameletbinding test to olm_upgrade_tes

["lfabriko (via GitHub)" <gi...@apache.org>]

lfabriko commented on code in PR #4245:
URL: https://github.com/apache/camel-k/pull/4245#discussion_r1164036824


##########
e2e/install/olm/olm_upgrade_test.go:
##########
@@ -196,40 +201,49 @@ func TestOLMAutomaticUpgrade(t *testing.T) {
 
 			// Check the Integration runs correctly
 			Eventually(IntegrationPodPhase(ns, name), TestTimeoutLong).Should(Equal(corev1.PodRunning))
+			Eventually(IntegrationPodPhase(ns, kbindName), TestTimeoutLong).Should(Equal(corev1.PodRunning))
+
 			Eventually(IntegrationConditionStatus(ns, name, v1.IntegrationConditionReady), TestTimeoutMedium).
 				Should(Equal(corev1.ConditionTrue))
+			Eventually(IntegrationConditionStatus(ns, kbindName, v1.IntegrationConditionReady), TestTimeoutMedium).Should(Equal(corev1.ConditionTrue))
 
 			// Check the Integration version has been upgraded
 			Eventually(IntegrationVersion(ns, name)).Should(ContainSubstring(newIPVersionPrefix))
+			Eventually(IntegrationVersion(ns, kbindName)).Should(ContainSubstring(newIPVersionPrefix))

Review Comment:
   I'm not sure if could be left some checks of underlying integration (also I noticed original checks of integration from L198 and L199 are repeated in the end)...
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org