[jira] [Commented] (ANY23-320) Address @Ignore tests in Any23

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ANY23-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307361#comment-16307361 ] 

ASF GitHub Bot commented on ANY23-320:
--------------------------------------

GitHub user lewismc opened a pull request:

    https://github.com/apache/any23/pull/55

    ANY23-320 Address @Ignore tests in Any23 and ANY23-131 Nested Microdata are not extracted

    Hi Folks, this PR addresses both https://issues.apache.org/jira/projects/ANY23/issues/ANY23-320 and https://issues.apache.org/jira/projects/ANY23/issues/ANY23-131
    
    Additionally, as usual this patch contains a significant volume of formatting and code convention improvements I encountered whilst attempting to fix the bugs associated with the above JIRA issues.
    
    It would be greatly appreciated if folks could pull this PR and test it out.
    Thanks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lewismc/any23 ANY23-320

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit 60e93a76748e53c413529409fb545e2245013639
Author: Lewis John McGibbney <le...@...>
Date:   2018-01-01T02:58:36Z

    ANY23-320 Address @Ignore tests in Any23 and ANY23-131 Nested Microdata are not extracted

----


> Address @Ignore tests in Any23
> ------------------------------
>
>                 Key: ANY23-320
>                 URL: https://issues.apache.org/jira/browse/ANY23-320
>             Project: Apache Any23
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.1
>            Reporter: Lewis John McGibbney
>             Fix For: 2.2
>
>
> There are several @Ignore test annotations we should address in Any23
> {code}
> ./cli/src/test/java/org/apache/any23/cli/ExtractorDocumentationTest.java
> ./cli/src/test/java/org/apache/any23/cli/RoverTest.java
> ./cli/src/test/java/org/apache/any23/cli/SimpleRoverTest.java
> ./core/src/test/java/org/apache/any23/extractor/html/HCardExtractorTest.java
> ./core/src/test/java/org/apache/any23/extractor/html/HListingExtractorTest.java
> ./core/src/test/java/org/apache/any23/extractor/microdata/MicrodataParserTest.java
> ./core/src/test/java/org/apache/any23/extractor/rdfa/RDFaExtractorTest.java
> ./service/src/test/java/org/apache/any23/servlet/ServletTest.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)