You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/21 09:54:05 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #9999: fix #9953

codelipenghui commented on a change in pull request #9999:
URL: https://github.com/apache/pulsar/pull/9999#discussion_r636791453



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##########
@@ -590,6 +591,10 @@ String getHandlerName() {
         internalConsumerConfig.setSubscriptionName(subscription);
         internalConsumerConfig.setConsumerName(consumerName);
         internalConsumerConfig.setMessageListener(null);
+        // output the org topic name
+        if (null != orgConf && internalConsumerConfig.getTopicNames().isEmpty()) {
+            internalConsumerConfig.getTopicNames().addAll(orgConf.getTopicNames());

Review comment:
       @xuesongxs It's not a correct fix here, we can't add all topics to the internal consumer since the internal consumer only connect to a single topic. I think we can fix the log directly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org