You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/08/15 06:34:57 UTC

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3978

Change subject: [util/env_posix.cc] fixed build on MacOS X
......................................................................

[util/env_posix.cc] fixed build on MacOS X

Fixed a tiny typo which broke build on MacOS X.
This is a follow-up for 13dde92b0fc42275c9bcc2954d0559830ac640e8.

Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
---
M src/kudu/util/env_posix.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/3978/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: [util/env_posix.cc] fixed build on MacOS X
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2890/

-- 
To view, visit http://gerrit.cloudera.org:8080/3978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [util/env_posix.cc] fixed build on MacOS X
......................................................................


Patch Set 1:

> oops, my bad!

np, and thank you for the instant review!

-- 
To view, visit http://gerrit.cloudera.org:8080/3978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [util/env_posix.cc] fixed build on MacOS X
......................................................................


Patch Set 1: Code-Review+2

oops, my bad!

-- 
To view, visit http://gerrit.cloudera.org:8080/3978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [util/env_posix.cc] fixed build on MacOS X
......................................................................


[util/env_posix.cc] fixed build on MacOS X

Fixed a tiny typo which broke build on MacOS X.
This is a follow-up for 13dde92b0fc42275c9bcc2954d0559830ac640e8.

Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Reviewed-on: http://gerrit.cloudera.org:8080/3978
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env_posix.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35c463c63132a17fd8d981fe0acb3e48a8f24318
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>