You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/30 15:34:22 UTC

[GitHub] [pinot] somandal commented on a diff in pull request #8993: Part 2 - Add support for multi-value noDict column types for group-by and filter type queries

somandal commented on code in PR #8993:
URL: https://github.com/apache/pinot/pull/8993#discussion_r911172129


##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java:
##########
@@ -164,8 +166,113 @@ private Map createGroupKeyMap(DataType keyType) {
 
   @Override
   public void generateKeysForBlock(TransformBlock transformBlock, int[][] groupKeys) {

Review Comment:
   This function is already implemented for `NoDictionaryMultiColumnGroupKeyGenerator`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org