You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/07/28 11:04:47 UTC
[GitHub] cordova-lib pull request #470: CB-11636 Handle attributes with quotes correc...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/470
CB-11636 Handle attributes with quotes correctly
This PR changes `mergeXml` inner implementation to avoid using `elementtree.findall()` with complex queries such as `tag[@attrib1="value1"][@attrib2="value2"]` to avoid issues with attributes w/ double quotes inside. Instead we use `findall('tag')` and the filter out unwanted candidates
For more details see [CB-11636](https://issues.apache.org/jira/browse/CB-11636) and [CB-11613](https://issues.apache.org/jira/browse/CB-11613)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-11636
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #470
----
commit e0f556333040594ddca7920100a1e6b64da866cc
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-07-28T09:44:59Z
CB-11636 Handle attributes with quotes correctly
Avoid using complex queries in et.findall to prevent
issues w/ quoted values. Previous approach w/ crafting
complex query from attributes names and values was faulty
when any of the attributes had double quotes or "
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #470: CB-11636 Handle attributes with quotes correctly
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/470
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #470: CB-11636 Handle attributes with quotes correctly
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/470
@stevengill, @purplecabbage, could you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #470: CB-11636 Handle attributes with quotes correctly
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/470
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/470?src=pr) is 80.62% (diff: 100%)
> Merging [#470](https://codecov.io/gh/apache/cordova-lib/pull/470?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage
```diff
@@ master #470 diff @@
==========================================
Files 68 68
Lines 5394 5394
Methods 855 855
Messages 0 0
Branches 1040 1040
==========================================
Hits 4349 4349
Misses 1045 1045
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [29382ca...5faad3c](https://codecov.io/gh/apache/cordova-lib/compare/29382ca2bf67e17337845feb4360980df99fe3d2...5faad3cdc39b4d2aefafe050c2f59921c566e97b?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #470: CB-11636 Handle attributes with quotes correc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org