You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/06/02 21:08:41 UTC
[jira] Commented: (HBASE-2618) Don't inherit from HConstants
[ https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874744#action_12874744 ]
stack commented on HBASE-2618:
------------------------------
Agreed. Here is current list that implements HConstants:
{code}
src/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
src/java/org/apache/hadoop/hbase/client/HConnectionManager.java
src/java/org/apache/hadoop/hbase/client/MetaScanner.java
src/java/org/apache/hadoop/hbase/master/BaseScanner.java
src/java/org/apache/hadoop/hbase/master/HMaster.java
src/java/org/apache/hadoop/hbase/master/RegionManager.java
src/java/org/apache/hadoop/hbase/master/ServerManager.java
src/java/org/apache/hadoop/hbase/master/TableOperation.java
src/java/org/apache/hadoop/hbase/migration/nineteen/regionserver/HStoreFile.java
src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
src/java/org/apache/hadoop/hbase/regionserver/HLog.java
src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/java/org/apache/hadoop/hbase/regionserver/Store.java
src/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
src/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
src/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
src/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
src/test/org/apache/hadoop/hbase/MiniHBaseCluster.java
src/test/org/apache/hadoop/hbase/PerformanceEvaluation.java
src/test/org/apache/hadoop/hbase/client/TestHTable.java
src/test/org/apache/hadoop/hbase/client/TestOldAPIHTable.java
src/test/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
src/test/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
src/test/org/apache/hadoop/hbase/regionserver/TestGetDeleteTracker.java
src/test/org/apache/hadoop/hbase/regionserver/TestHLog.java
src/test/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java
src/test/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
src/test/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java
src/test/org/apache/hadoop/hbase/regionserver/TestWildcardColumnTracker.java
{code}
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad pattern and is recommended against in many places including Effective Java (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.