You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/05/27 06:50:58 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #5925: The storage format is not converted from v1 to v2 by default when alter table's schema
caiconghui opened a new pull request #5925:
URL: https://github.com/apache/incubator-doris/pull/5925
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #5924 ) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #5925: The storage format should not be converted from v1 to v2 by default when alter table's schema
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #5925:
URL: https://github.com/apache/incubator-doris/pull/5925#issuecomment-851108048
We need to update to segment V2 and remove the v1 code from the code base. If this is done, this will be delayed indefinitely. If it is for the stability of online users, this part of users can stay in A certain version, segment v2 has gone through 3 versions from 0.12 to the current 0.14. If we should not have any way to create a new v1 table in the current code, we should keep the v1 table read-only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui closed pull request #5925: The storage format should not be converted from v1 to v2 by default when alter table's schema
Posted by GitBox <gi...@apache.org>.
caiconghui closed pull request #5925:
URL: https://github.com/apache/incubator-doris/pull/5925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] stdpain commented on pull request #5925: The storage format should not be converted from v1 to v2 by default when alter table's schema
Posted by GitBox <gi...@apache.org>.
stdpain commented on pull request #5925:
URL: https://github.com/apache/incubator-doris/pull/5925#issuecomment-849527881
SegmentV1 will be deprecated in the future, so I don't think this change is necessary.
Insisting on maintaining SegmentV1 will be a big burden in future vectorization support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #5925: The storage format should not be converted from v1 to v2 by default when alter table's schema
Posted by GitBox <gi...@apache.org>.
caiconghui commented on pull request #5925:
URL: https://github.com/apache/incubator-doris/pull/5925#issuecomment-849659166
> SegmentV1 will be deprecated in the future, so I don't think this change is necessary.
> Insisting on maintaining SegmentV1 will be a big burden in future vectorization support
Yes , I agree with you that SegmentV1 will be deprecated in the future, segment V2 will replace all segment v1 in the future.
This PR is not Insisting on maintaining SegmentV1 but to be compatible with older doris version.
For new doris user , This PR doesn't take any effect, all newer table will be created by segment v2
For older doris user, there are many tables with segment v1, and it need to gradually change V1 to v2,
actually, for many older doris user, the most important thing is stable on production enviroment, but now, Very few alter operations succeed, most fail due to timeout, because convert v1 to v2 is a huge task which would cost a lot of time while there are many tablets in older table. and once timeout, all operations that convert v1 to v2 would rollback, which is not what we expect, and make doris not friendly to older user
If we always alter table failed, it is meanless to convert v1 to v2 when do alter table, I think it is not a good idea to convert v1 to v2 when user just want to add column for table, which now seems an impossible goal to achive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org