You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/27 08:43:38 UTC
[GitHub] [spark] zhengruifeng commented on a diff in pull request #37770: [SPARK-40314][SQL][PYTHON] Add scala and python bindings for inline and inline_outer
zhengruifeng commented on code in PR #37770:
URL: https://github.com/apache/spark/pull/37770#discussion_r980946968
##########
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala:
##########
@@ -219,20 +219,21 @@ class GeneratorFunctionSuite extends QueryTest with SharedSparkSession {
test("inline raises exception on array of null type") {
val m = intercept[AnalysisException] {
- spark.range(2).selectExpr("inline(array())")
Review Comment:
can we leave existing UTs alone and add extra tests in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org