[GitHub] [spark] rdblue commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

[GitBox <gi...@apache.org>]

rdblue commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-511939893
 
 
   I think there are a couple motivations for splitting PRs into smaller parts:
   1. To make review easier
   2. To avoid changes in the same commit that may be cherry-picked or reverted separately
   
   Since we've already reviewed this as-is, I agree with @brkyvz. There isn't much advantage to splitting it now to make reviewing easier.
   
   The second point is usually my main concern. But in this case, I think it is unlikely that a user would want to cherry-pick or revert these changes separately. RTAS and CTAS are mostly useless without the staging API, and vice versa. Separating REPLACE from CREATE might be reasonable, but as we discussed in the sync, REPLACE can be disabled by sources without removing the code for it. So I think there isn't much of a reason for maintenance purposes to split this up either.
   
   I think we should move forward with this. But in the future, let's keep commits smaller and more focused.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org