You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/11 22:39:53 UTC
[GitHub] [camel-k] nicolaferraro opened a new pull request #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
nicolaferraro opened a new pull request #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
URL: https://github.com/apache/camel-k/pull/1269
…ution
<!-- Description -->
cc: @astefanutti
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Fixed x509 certificate errors for Knative serving services on OpenShift
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti edited a comment on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
URL: https://github.com/apache/camel-k/pull/1269#issuecomment-585108391
That works also for Buildah: https://github.com/apache/camel-k/pull/1259/commits/384541ddd5a92079fba1e232c47c2674187f1393#diff-8bfaca691ee0b99d585e230595d49e6aR230.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti merged pull request #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
URL: https://github.com/apache/camel-k/pull/1269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
URL: https://github.com/apache/camel-k/pull/1269#issuecomment-585097889
I'm trying to replicate this with Buildah in the context of #1259. I've just realised Buildah is returning the image Id digest, which is different from the repository digest :( Once I've managed to retrieve the correct digest, I'll factorize the code for Buildah and s2i.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1269: fix #1222: use image sha in s2i build to avoid knative registry resol…
URL: https://github.com/apache/camel-k/pull/1269#issuecomment-585108391
That works also for Buildah: https://github.com/apache/camel-k/pull/1259/commits/a095724a23f564cca811d77ad311dd5c55c90307#diff-8bfaca691ee0b99d585e230595d49e6aR230.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services