You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by zwoop <gi...@git.apache.org> on 2016/10/04 17:10:48 UTC
[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1076
TS-4929: No loading of HostDB disk file if sync_frequency=0
This has two benefit (2) is most important I think:
1) We avoid warnings on startup about not being able to load the HostDB.
2) Since in 7.0.0, turning off syncing (sync_frequency=0) completely disables writing to HostDB, it's now possible to end up loading a potentially stale HostDB from a previous upgrade.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4929
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1076
----
commit b89513b698ea72a09cb700a83ee4102413a708e8
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-10-04T16:54:31Z
TS-4929: No loading of HostDB disk file if sync_frequency=0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1076
@zwoop (1) and (2) sound like they are in conflict? I'm confused about whether it loads or not? If it does load, do you really have a stale record problem, since each record has a TTL?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1076
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/928/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1076
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/822/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1076
Yes, they would have TTLs, but if I turned off syncing, I certainly wouldn't expect it to load something old. What if I had bad entries? What if I had a corruption of some sort? Since it will never update it, you are stuck with loading old (possibly stale or more likely expired) entries for the remaining of life? That just makes no sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1076
OK that sounds reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---