You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2008/03/24 23:43:24 UTC

[jira] Created: (SHINDIG-151) gadgets.window.adjustHeight() fails on IE 6

gadgets.window.adjustHeight() fails on IE 6
-------------------------------------------

                 Key: SHINDIG-151
                 URL: https://issues.apache.org/jira/browse/SHINDIG-151
             Project: Shindig
          Issue Type: Bug
          Components: OpenSocial - Javascript
         Environment: IE 6, windows XP
            Reporter: Paul Lindner


>From our esteemed js guru Mike Austin:

The problem is in this code:
 
var oh = docEl.offsetHeight;
 
if (docEl.clientHeight != oh) {
    sh = body.scrollHeight;
    oh = body.offsetHeight;
}
 
Both offsetHeight and clientHeight are 0, so the code doesn't get executed for IE6.  You can change the test to "if(document.all)" for a fix, but someone at google should look deeper into this, especially if it worked before.
 
Mike
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-151) gadgets.window.adjustHeight() fails on IE 6

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595809#action_12595809 ] 

Kevin Brown commented on SHINDIG-151:
-------------------------------------

Has anyone been able to reproduce this? Paul?

> gadgets.window.adjustHeight() fails on IE 6
> -------------------------------------------
>
>                 Key: SHINDIG-151
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-151
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>         Environment: IE 6, windows XP
>            Reporter: Paul Lindner
>
> From our esteemed js guru Mike Austin:
> The problem is in this code:
>  
> var oh = docEl.offsetHeight;
>  
> if (docEl.clientHeight != oh) {
>     sh = body.scrollHeight;
>     oh = body.offsetHeight;
> }
>  
> Both offsetHeight and clientHeight are 0, so the code doesn't get executed for IE6.  You can change the test to "if(document.all)" for a fix, but someone at google should look deeper into this, especially if it worked before.
>  
> Mike
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-151) gadgets.window.adjustHeight() fails on IE 6

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-151.
----------------------------------

    Resolution: Cannot Reproduce

Marking this cannot reproduce for now.  We will re-test with shindig trunk at a future point.

It's likely that this problem was caused by the integration of the resize JS and DOM load timing etc..


> gadgets.window.adjustHeight() fails on IE 6
> -------------------------------------------
>
>                 Key: SHINDIG-151
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-151
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>         Environment: IE 6, windows XP
>            Reporter: Paul Lindner
>
> From our esteemed js guru Mike Austin:
> The problem is in this code:
>  
> var oh = docEl.offsetHeight;
>  
> if (docEl.clientHeight != oh) {
>     sh = body.scrollHeight;
>     oh = body.offsetHeight;
> }
>  
> Both offsetHeight and clientHeight are 0, so the code doesn't get executed for IE6.  You can change the test to "if(document.all)" for a fix, but someone at google should look deeper into this, especially if it worked before.
>  
> Mike
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-151) gadgets.window.adjustHeight() fails on IE 6

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown updated SHINDIG-151:
--------------------------------

    Component/s:     (was: OpenSocial  feature (Javascript))
                 Features (Javascript)

> gadgets.window.adjustHeight() fails on IE 6
> -------------------------------------------
>
>                 Key: SHINDIG-151
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-151
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>         Environment: IE 6, windows XP
>            Reporter: Paul Lindner
>
> From our esteemed js guru Mike Austin:
> The problem is in this code:
>  
> var oh = docEl.offsetHeight;
>  
> if (docEl.clientHeight != oh) {
>     sh = body.scrollHeight;
>     oh = body.offsetHeight;
> }
>  
> Both offsetHeight and clientHeight are 0, so the code doesn't get executed for IE6.  You can change the test to "if(document.all)" for a fix, but someone at google should look deeper into this, especially if it worked before.
>  
> Mike
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-151) gadgets.window.adjustHeight() fails on IE 6

Posted by "Zhen Wang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588168#action_12588168 ] 

Zhen Wang commented on SHINDIG-151:
-----------------------------------

I can't reproduce the bug in IE6/XP. The dynamic-height call gets executed correctly.
Do you have a sample gadget that fails to adjust its height?

> gadgets.window.adjustHeight() fails on IE 6
> -------------------------------------------
>
>                 Key: SHINDIG-151
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-151
>             Project: Shindig
>          Issue Type: Bug
>          Components: OpenSocial - Javascript
>         Environment: IE 6, windows XP
>            Reporter: Paul Lindner
>
> From our esteemed js guru Mike Austin:
> The problem is in this code:
>  
> var oh = docEl.offsetHeight;
>  
> if (docEl.clientHeight != oh) {
>     sh = body.scrollHeight;
>     oh = body.offsetHeight;
> }
>  
> Both offsetHeight and clientHeight are 0, so the code doesn't get executed for IE6.  You can change the test to "if(document.all)" for a fix, but someone at google should look deeper into this, especially if it worked before.
>  
> Mike
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.