You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/03 08:19:33 UTC
[GitHub] [incubator-ratis] adoroszlai opened a new pull request #85: RATIS-639. Inconsistent pattern for variable names
adoroszlai opened a new pull request #85:
URL: https://github.com/apache/incubator-ratis/pull/85
## What changes were proposed in this pull request?
1. Allow variable names like `v1` in expressions, too
2. Allow expressions like `0.1 + 0.2`
3. Fix `NumberFormatException` for expression like `-5`
https://issues.apache.org/jira/browse/RATIS-639
## How was this patch tested?
Added test cases in unit test. Also tested manually via CLI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] bshashikant merged pull request #85: RATIS-639. Inconsistent pattern for variable names
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #85:
URL: https://github.com/apache/incubator-ratis/pull/85
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] adoroszlai commented on pull request #85: RATIS-639. Inconsistent pattern for variable names
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #85:
URL: https://github.com/apache/incubator-ratis/pull/85#issuecomment-629602817
Thanks @bshashikant for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org