You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "xxeol2 (via GitHub)" <gi...@apache.org> on 2023/09/05 15:46:15 UTC
[GitHub] [tomcat] xxeol2 opened a new pull request, #657: Eliminating duplicate execution of checkFacade logic in ResponseFacade
xxeol2 opened a new pull request, #657:
URL: https://github.com/apache/tomcat/pull/657
https://github.com/apache/tomcat/pull/654#issuecomment-1706706294
This was discussed in the comments above!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #657: Eliminating duplicate execution of checkFacade logic in ResponseFacade
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf merged PR #657:
URL: https://github.com/apache/tomcat/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a diff in pull request #657: Eliminating duplicate execution of checkFacade logic in ResponseFacade
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316282831
##########
java/org/apache/catalina/connector/ResponseFacade.java:
##########
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public ServletOutputStream getOutputStream() throws IOException {
- checkFacade();
- ServletOutputStream sos = response.getOutputStream();
if (isFinished()) {
response.setSuspended(true);
}
- return sos;
+ return response.getOutputStream();
}
@Override
public PrintWriter getWriter() throws IOException {
- checkFacade();
- PrintWriter writer = response.getWriter();
if (isFinished()) {
response.setSuspended(true);
}
- return writer;
+ return response.getWriter();
Review Comment:
There is an extra space here that needs to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] xxeol2 commented on a diff in pull request #657: Eliminating duplicate execution of checkFacade logic in ResponseFacade
Posted by "xxeol2 (via GitHub)" <gi...@apache.org>.
xxeol2 commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316480032
##########
java/org/apache/catalina/connector/ResponseFacade.java:
##########
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public ServletOutputStream getOutputStream() throws IOException {
- checkFacade();
- ServletOutputStream sos = response.getOutputStream();
if (isFinished()) {
response.setSuspended(true);
}
- return sos;
+ return response.getOutputStream();
}
@Override
public PrintWriter getWriter() throws IOException {
- checkFacade();
- PrintWriter writer = response.getWriter();
if (isFinished()) {
response.setSuspended(true);
}
- return writer;
+ return response.getWriter();
Review Comment:
@markt-asf I removed that extra space! Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org