You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/25 03:47:44 UTC
[GitHub] [iceberg] chenjunjiedada opened a new pull request #1377: Flink: optimize the parquet writer getter method
chenjunjiedada opened a new pull request #1377:
URL: https://github.com/apache/iceberg/pull/1377
This is a follow up for #1272.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenjunjiedada commented on a change in pull request #1377: Flink: optimize the parquet writer getter method
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on a change in pull request #1377:
URL: https://github.com/apache/iceberg/pull/1377#discussion_r476128705
##########
File path: flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetWriters.java
##########
@@ -424,13 +428,7 @@ public boolean hasNext() {
throw new NoSuchElementException();
}
- if (values.isNullAt(index)) {
- entry.set((K) ArrayData.createElementGetter(keyType).getElementOrNull(keys, index), null);
- } else {
- entry.set((K) ArrayData.createElementGetter(keyType).getElementOrNull(keys, index),
- (V) ArrayData.createElementGetter(valueType).getElementOrNull(values, index));
- }
-
+ entry.set((K) keyGetter.getElementOrNull(keys, index), (V) valueGetter.getElementOrNull(values, index));
Review comment:
The `ArrayData` interface only defines `getElementOrNull`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1377: Flink: optimize the parquet writer getter method
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1377:
URL: https://github.com/apache/iceberg/pull/1377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1377: Flink: optimize the parquet writer getter method
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1377:
URL: https://github.com/apache/iceberg/pull/1377#issuecomment-680163216
Thanks for the quick follow-up, @chenjunjiedada!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org