You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2024/04/29 14:18:01 UTC
[I] Out of date comment in TabletServerMetricsUtil [accumulo]
DomGarguilo opened a new issue, #4501:
URL: https://github.com/apache/accumulo/issues/4501
**Describe the bug**
TabletServerMetricsUtil javadoc mentions Hadoop metrics2 which we no longer use. This comment should be updated.
https://github.com/apache/accumulo/blob/e682a2f2296cf95a32d58250aeef612b61147936/server/tserver/src/main/java/org/apache/accumulo/tserver/metrics/TabletServerMetricsUtil.java#L25-L29
**Versions (OS, Maven, Java, and others, as appropriate):**
- Affected version(s) of this project: 2.1.2 and up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Out of date comment in TabletServerMetricsUtil [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #4501:
URL: https://github.com/apache/accumulo/issues/4501#issuecomment-2083639339
Fixed by #4503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Out of date comment in TabletServerMetricsUtil [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #4501:
URL: https://github.com/apache/accumulo/issues/4501#issuecomment-2082889007
Did a quick search and found these mentions of hadoop metrics2 as well:
https://github.com/apache/accumulo/blob/6d0b4768522187d8c43b9bf0850034d80a684235/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L386-L387
https://github.com/apache/accumulo/blob/6d0b4768522187d8c43b9bf0850034d80a684235/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L928-L929
These could probably all be fixed in one PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Out of date comment in TabletServerMetricsUtil [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on issue #4501:
URL: https://github.com/apache/accumulo/issues/4501#issuecomment-2082941512
MANAGER_FATE_METRICS_ENABLED and MANAGER_FATE_METRICS_ENABLED Look like they are unused and have been marked deprecated. If so, maybe they can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Out of date comment in TabletServerMetricsUtil [accumulo]
Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman closed issue #4501: Out of date comment in TabletServerMetricsUtil
URL: https://github.com/apache/accumulo/issues/4501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org