[GitHub] [hudi] yanghua commented on a change in pull request #3123: [HUDI-2049] StreamWriteFunction should wait for the next inflight ins…

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #3123:
URL: https://github.com/apache/hudi/pull/3123#discussion_r655220200



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -494,7 +493,7 @@ private boolean flushBucket(DataBucket bucket) {
       long waitingTime = 0L;
       long ckpTimeout = config.getLong(FlinkOptions.WRITE_COMMIT_ACK_TIMEOUT);
       long interval = 500L;
-      while (Objects.equals(instant, this.currentInstant)) {
+      while (instant == null || instant.equals(this.currentInstant)) {

Review comment:
       in the case: `instant == null`, you have returned before? 
   
   ```
       if (instant == null) {
         // in case there are empty checkpoints that has no input data
         LOG.info("No inflight instant when flushing data, skip.");
         return false;
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org