You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/23 02:21:58 UTC
[jira] [Commented] (SAMZA-1066) Update JavaStorageConfig after LISAMZA-1060

    [ https://issues.apache.org/jira/browse/SAMZA-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771647#comment-15771647 ] 

ASF GitHub Bot commented on SAMZA-1066:
---------------------------------------

GitHub user sborya opened a pull request:

    https://github.com/apache/samza/pull/36

    JavaStorageConfig handling job.changelog.system

    SAMZA-1066
    
    Same as change for StorageConfig.java
    Allows user to set changelog system in job.changelog.system and specify stream only in 'stores.<store>.changelog'

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sborya/samza JavaStorageConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit c76baefcb49a01238a767045288fbda31b312c1e
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-09T22:29:18Z

    added new config for job.changelog.system

commit a8e45377a44e4c28abef3880d08419802f3a2519
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-13T22:39:27Z

    added catch error for StoreConfig and a test for it

commit cc1d738b7b42bac86f4df7bb8dd2e93bad2f82c9
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-14T00:46:23Z

    rearranged if condition in StoreConfig

commit ac9498bd1e2afc1dc8b283b6696a2d6b61d8fd75
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-15T17:29:19Z

    Merge branch 'master' of https://github.com/apache/samza

commit ecc96f6e0d68c4200638af37259650c9e5e59b92
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-15T18:20:41Z

    added doc for job.changelog.system config

commit 3cf4b86666a3d211db495f0fbc63eccde8dffadc
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-15T18:28:18Z

    typo

commit c7d69c85757b95830972559391854f835b8b52a8
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-15T22:38:47Z

    address review comments

commit 5db5d3f9c3b9a9b4d50debb45ac8b5eb7a800f81
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-15T23:01:53Z

    Changed User to You

commit cffc83a139a829b9d3dbb018ae0e0e3ac92023e6
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-23T02:15:27Z

    Merge branch 'master' of https://github.com/apache/samza

commit 6c12f280e6f137adcaaf0814d8e68bb143be66fd
Author: Boris Shkolnik <bs...@bshkolni-ld1.linkedin.biz>
Date:   2016-12-23T02:16:50Z

    Added handling of job.changelog.system config to JavaStorageConfig

----


> Update JavaStorageConfig after LISAMZA-1060
> -------------------------------------------
>
>                 Key: SAMZA-1066
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1066
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Navina Ramesh
>            Assignee: Boris Shkolnik
>
> Changes made for LISAMZA-1060 affects any code path using JavaStorageConfig.java, instead of StorageConfig.scala. 
> Please fix getChangelogStream in JavaStorageConfig and make sure that there are no other inconsistencies between StorageConfig and JavaStorageConfig.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)