[jira] [Commented] (DRILL-5319) Refactor FragmentContext and OptionManager for unit testing

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957592#comment-15957592 ] 

ASF GitHub Bot commented on DRILL-5319:
---------------------------------------

Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/787#discussion_r109982950
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionSet.java ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.server.options;
    +
    +/**
    + * Immutable set of options accessible by name or validator.
    + */
    +
    +public interface OptionSet {
    --- End diff --
    
    Maybe rename to OptionReader instead of OptionSet. An OptionManager would extend an OptionReader and OptionModifier interfaces.


> Refactor FragmentContext and OptionManager for unit testing
> -----------------------------------------------------------
>
>                 Key: DRILL-5319
>                 URL: https://issues.apache.org/jira/browse/DRILL-5319
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Tools, Build & Test
>    Affects Versions: 1.10.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.11.0
>
>
> Roll-up task for two refactorings, see the sub-tasks for details. This ticket allows a single PR for the two different refactorings since the work heavily overlaps. See DRILL-5320 and DRILL-5321 for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)