[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1724: [CELEBORN-803] Increase default timeout for commit files

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1724:
URL: https://github.com/apache/incubator-celeborn/pull/1724#discussion_r1265443693


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2147,7 +2147,7 @@ object CelebornConf extends Logging {
       .doc("Timeout for a Celeborn worker to commit files of a shuffle. " +
         "It's recommended to set at least `240s` when `HDFS` is enabled in `celeborn.storage.activeTypes`.")
       .version("0.3.0")
-      .fallbackConf(RPC_ASK_TIMEOUT)
+      .fallbackConf(NETWORK_TIMEOUT)

Review Comment:
   I think you are right. I just increased the timeout and max retries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org