You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/18 05:45:18 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #294:
arch: Customize the typedef of size_t instead of intptr_t
xiaoxiang781216 opened a new pull request #294: arch: Customize the typedef of size_t instead of intptr_t
URL: https://github.com/apache/incubator-nuttx/pull/294
to ensure size_t same as toolchain definition in the first
place and rename CXX_NEWLONG to ARCH_SIZET_LONG.
The change also check whether __SIZE_TYPE__ exist before
CONFIG_ARCH_SIZET_LONG so our definition can align with
toolchain(gcc/clang) definition automatically.
Change-Id: I3d9ba7d27edd87c496aeea70ca2cde25b5f2141a
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #294: arch:
Customize the typedef of size_t instead of intptr_t
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #294: arch: Customize the typedef of size_t instead of intptr_t
URL: https://github.com/apache/incubator-nuttx/pull/294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #294: arch:
Customize the typedef of size_t instead of intptr_t
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #294: arch: Customize the typedef of size_t instead of intptr_t
URL: https://github.com/apache/incubator-nuttx/pull/294#issuecomment-587293400
This patch has the following improvement:
1.typedef size_t to different type base on CONFIG_ARCH_SIZET_LONG, so we don't need hack operator new overload function. This is important because it avoid us to modify the 3rd party c++ library code.
2.typdef size_t to __SIZE_TYPE__ if this macro exist. some compiler(gcc/clang at least) define this macro to match their size_t type. So we don't need change CONFIG_ARCH_SIZET_LONG in the most case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #294: arch:
Customize the typedef of size_t instead of intptr_t
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #294: arch: Customize the typedef of size_t instead of intptr_t
URL: https://github.com/apache/incubator-nuttx/pull/294#issuecomment-587415108
Here has more background info:
https://github.com/apache/incubator-nuttx/pull/131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services