You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/20 17:56:38 UTC

[GitHub] [arrow] westonpace opened a new pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

westonpace opened a new pull request #10757:
URL: https://github.com/apache/arrow/pull/10757


   The streaming CSV reader now creates more threads even when use_threads = false (it creates a CPU thread to do the worker tasks in an async way safe for nested parallelism).  This disturbs RTools 3.5 builds on Windows on 32 bit machines.  Per some discussion in Zulip I am disabling those tests as it is not clear the functionality is needed (i.e. it is not clear that there are many 32-bit consumers).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883590367


   @github-actions crossbow submit test-r-rtools-35


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883694260


   It appears the fourth time is the charm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883622508


   Revision: 4430f8222cf169e13f85d6e2210ca9708b269b39
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-627](https://github.com/ursacomputing/crossbow/branches/all?query=actions-627)
   
   |Task|Status|
   |----|------|
   |test-r-rtools-35|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-627-github-test-r-rtools-35)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-627-github-test-r-rtools-35)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883658427


   gah, we need to rerender the docs, I'll pull and do that (there's a little trick to it these days)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883638254


   Revision: dc6a81b81f7210bdb900e39a03ce12a75ad5cd35
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-628](https://github.com/ursacomputing/crossbow/branches/all?query=actions-628)
   
   |Task|Status|
   |----|------|
   |test-r-rtools-35|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-628-github-test-r-rtools-35)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-628-github-test-r-rtools-35)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883721297


   > Hmm, RTools 4.0 timed out.
   
   I *think* that failure mode is unrelated to our code. I restarted the builds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883715986


   Hmm, RTools 4.0 timed out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883660901


   Revision: da57c3ec4a187fe42f061551472066aee91fb62d
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-629](https://github.com/ursacomputing/crossbow/branches/all?query=actions-629)
   
   |Task|Status|
   |----|------|
   |test-r-rtools-35|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-629-github-test-r-rtools-35)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-629-github-test-r-rtools-35)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#discussion_r673410017



##########
File path: r/R/dataset-format.R
##########
@@ -53,7 +53,7 @@
 #' It returns the appropriate subclass of `FileFormat` (e.g. `ParquetFileFormat`)
 #' @rdname FileFormat
 #' @name FileFormat
-#' @examplesIf arrow_with_dataset()
+#' @examplesIf arrow_with_dataset() && tolower(Sys.info()[["sysname"]]) == "windows"

Review comment:
       Oops, this is run-if, not skip-if
   
   ```suggestion
   #' @examplesIf arrow_with_dataset() && tolower(Sys.info()[["sysname"]]) != "windows"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883637771


   @github-actions crossbow submit test-r-rtools-35


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883660393


   @github-actions crossbow submit test-r-rtools-35


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883722295


   It looks like, in the last 30 days, it happened 3 times and one of them did happen before the streaming CSV reader change so I think we're ok but definitely something to monitor.
   
   https://github.com/apache/arrow/runs/3076555082?check_suite_focus=true
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883622578


   Ah, dataset inspection requires grabbing the schema from one or more files which, for CSV, means starting and then abandoning a read.  Also, a glitch in my test skip.  However, it appears we are skipping the right set of tests since it reported tests failed and didn't crash.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883621990


   @github-actions crossbow submit test-r-rtools-35


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace closed pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #10757:
URL: https://github.com/apache/arrow/pull/10757


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883616820


   I guess we'll see. The output from the failed build seems to suggest that it might fail: https://github.com/ursacomputing/crossbow/runs/3104398258#step:11:425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883590884


   Revision: df027676c8f026814993c17d26799548fb4ed832
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-626](https://github.com/ursacomputing/crossbow/branches/all?query=actions-626)
   
   |Task|Status|
   |----|------|
   |test-r-rtools-35|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-626-github-test-r-rtools-35)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-626-github-test-r-rtools-35)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883584399


   https://issues.apache.org/jira/browse/ARROW-13386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883615011


   I think that one is ok because it doesn't actually collect the dataset.  Opening a dataset should still be fine.  I just now scanned around and there are three examples that have `If arrow_with_dataset()` and only one of them collects the dataset and it doesn't use CSV.  Let's wait and see how the crossbow job does.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #10757: ARROW-13386: [R][C++] CSV streaming changes break Rtools 35 32-bit build

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10757:
URL: https://github.com/apache/arrow/pull/10757#issuecomment-883608751


   We'll also need to skip (at least one) example: https://github.com/apache/arrow/blob/master/r/R/dataset-format.R#L56 IMO just add `&& tolower(Sys.info()[["sysname"]]) == "windows"` to that line


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org