You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2022/10/18 23:41:21 UTC
[GitHub] [shiro] julian-computes opened a new pull request, #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
julian-computes opened a new pull request, #499:
URL: https://github.com/apache/shiro/pull/499
In 1.10.0, an NPE can be thrown because DefaultWebEnvironment has no default value for ShiroFilterConfiguration. This commit adds a default value determined by WebEnvironment.getShiroFilterConfiguration().
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell merged pull request #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
Posted by GitBox <gi...@apache.org>.
bmarwell merged PR #499:
URL: https://github.com/apache/shiro/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
Posted by GitBox <gi...@apache.org>.
fpapon commented on PR #499:
URL: https://github.com/apache/shiro/pull/499#issuecomment-1291607684
@julian-computes Can you squash the commits please? It's better to have only one for the history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] julian-computes commented on pull request #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
Posted by GitBox <gi...@apache.org>.
julian-computes commented on PR #499:
URL: https://github.com/apache/shiro/pull/499#issuecomment-1291154798
@bmarwell I've just done so. Apologies for the extra merge commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] julian-computes commented on pull request #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
Posted by GitBox <gi...@apache.org>.
julian-computes commented on PR #499:
URL: https://github.com/apache/shiro/pull/499#issuecomment-1292001975
Yes, true. Squashed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on pull request #499: [SHIRO-893] - Fix NPE in ShiroFilter.init()
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #499:
URL: https://github.com/apache/shiro/pull/499#issuecomment-1290981698
@julian-computes can you please rename the commit message so we get a `[SHIRO-893] ` in front?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org