You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 04:08:56 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1890: Add validation to `RecordBatch` for non-nullable fields containing null values

viirya commented on code in PR #1890:
URL: https://github.com/apache/arrow-rs/pull/1890#discussion_r899744945


##########
arrow/src/record_batch.rs:
##########
@@ -138,6 +138,19 @@ impl RecordBatch {
                 )
             })?;
 
+        for (c, f) in columns.iter().zip(&schema.fields) {
+            if !f.is_nullable() && c.null_count() > 0 {
+                // hacky workaround for known issue with dictionary IPC encoding
+                // https://github.com/apache/arrow-rs/issues/1892

Review Comment:
   #1893 should fix this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org