You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/06 07:29:04 UTC

[GitHub] [shardingsphere] xbkaishui opened a new pull request #6276: add help command for proxy start up script

xbkaishui opened a new pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276


   Fixes #6273 
   
   Changes proposed in this pull request:
   - add help command
   
   examples: 
   
   sh bin/start.sh -h
   
   usage: start.sh [port] [config_dir]
     port: proxy listen port, default is 3307
     config_dir: proxy config directory, default is conf
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 merged pull request #6276: add help command for proxy start up script

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6276: add help command for proxy start up script

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276#discussion_r450180569



##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.bat
##########
@@ -27,6 +27,13 @@ set PORT=%1
 
 set CONFIG=%2
 
+if "%PORT%"=="-h" (
+    goto print_usage
+)
+if "%PORT%"=="-help" (

Review comment:
       sorry miss - 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6276: add help command for proxy start up script

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276#discussion_r450170549



##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.sh
##########
@@ -38,6 +38,17 @@ JAVA_MEM_OPTS=" -server -Xmx2g -Xms2g -Xmn1g -Xss256k -XX:+DisableExplicitGC -XX
 
 MAIN_CLASS=org.apache.shardingsphere.proxy.Bootstrap
 
+print_usage() {

Review comment:
       there's another start.sh file. Please find it.

##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.bat
##########
@@ -27,6 +27,13 @@ set PORT=%1
 
 set CONFIG=%2
 
+if "%PORT%"=="-h" (

Review comment:
       Why .bat is different from .sh and use goto?

##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.bat
##########
@@ -27,6 +27,13 @@ set PORT=%1
 
 set CONFIG=%2
 
+if "%PORT%"=="-h" (
+    goto print_usage
+)
+if "%PORT%"=="-help" (

Review comment:
       original intention --help?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6276: add help command for proxy start up script

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276#discussion_r450174687



##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.bat
##########
@@ -27,6 +27,13 @@ set PORT=%1
 
 set CONFIG=%2
 
+if "%PORT%"=="-h" (
+    goto print_usage
+)
+if "%PORT%"=="-help" (

Review comment:
       Why .bat is different from .sh and use goto?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6276: add help command for proxy start up script

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6276:
URL: https://github.com/apache/shardingsphere/pull/6276#discussion_r450180908



##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/src/main/resources/bin/start.bat
##########
@@ -27,6 +27,13 @@ set PORT=%1
 
 set CONFIG=%2
 
+if "%PORT%"=="-h" (

Review comment:
       windows bat is a little difference with bash,  it use goto as a function call




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org