You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by gi...@git.apache.org on 2017/07/27 02:57:03 UTC

[GitHub] eolivelli commented on issue #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

eolivelli commented on issue #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#issuecomment-318244413
 
 
   @sijie 
   overall I am not very happy with this patch, as I told on the mailing list, addressing the problem with method overloading + default method interface is messy.
   
   I would prefer to break compatibility once and create a better API, packaging method parameters in contextual beans
   like
   
   initialize(ClientEnvironment env)
   newEnsemble(LedgerSpecs specs)
   replaceBookie(LedgerSpecs specs, bookietoreplace, ReplaceContext ctx)
   ......
   
   /cc @merlimat @jvrao @ivankelly 
   in the future maybe we will add support for "Bookie pools/labels", ACLs (so user context....).....
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services