You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by to...@apache.org on 2005/12/19 01:32:11 UTC
svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/
tools/build-tools.jar tools/src/
Author: tomsp
Date: Sun Dec 18 16:32:06 2005
New Revision: 357582
URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
Log:
facelet support
Added:
myfaces/build/trunk/facelets-build.xml
myfaces/build/trunk/tools/
myfaces/build/trunk/tools/build-tools.jar (with props)
myfaces/build/trunk/tools/src/
Added: myfaces/build/trunk/facelets-build.xml
URL: http://svn.apache.org/viewcvs/myfaces/build/trunk/facelets-build.xml?rev=357582&view=auto
==============================================================================
--- myfaces/build/trunk/facelets-build.xml (added)
+++ myfaces/build/trunk/facelets-build.xml Sun Dec 18 16:32:06 2005
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="iso-8859-1"?>
+<project name="facelets-build" default="facelets-taglibs">
+
+ <property name="build.dir" location="${basedir}"/>
+ <property name="lib.dir" location="${build.dir}/../lib"/>
+
+ <!-- needed libs
+ build/dist/myfaces-all.jar
+ build/tools/build-tools.jar
+ sandbox/build/dist/sandbox.jar
+ lib/common-beanutils.jar
+ lib/common-collections.jar
+ lib/common-digester.jar
+ lib/common-logging.jar
+ lib/jsp.jar
+ -->
+ <target name="facelets-taglibs" >
+ <taskdef name="faceletstask"
+ classname="org.apache.myfaces.tools.FaceletsTaglibTask" />
+
+ <faceletstask sourceTld="${build.dir}/../tomahawk/build/temp/tlds/tomahawk.tld" targetFile="${build.dir}/dist/tomahawk.taglib.xml" />
+ <faceletstask sourceTld="${build.dir}/../sandbox/build/temp/tlds/myfaces_sandbox.tld" targetFile="${build.dir}/dist/sandbox.taglib.xml" />
+ </target>
+</project>
\ No newline at end of file
Added: myfaces/build/trunk/tools/build-tools.jar
URL: http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
==============================================================================
Binary file - no diff available.
Propchange: myfaces/build/trunk/tools/build-tools.jar
------------------------------------------------------------------------------
svn:mime-type = application/octet-stream
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/ tools/build-tools.jar tools/src/
Posted by Thomas Spiegl <th...@gmail.com>.
Simon, I know. It's intended to be a temporary solution.
Thomas
On 12/19/05, Simon Kitching <sk...@obsidium.com> wrote:
>
> Hi Thomas,
>
> It's not the size; it's the principle of adding binary files that people
> must execute in order to build from source (which I presume is what this
> jar is for).
>
> I understand that people need to use binary builds of Ant or Maven in
> order to build, but nevertheless I'm not aware of any other projects
> that require binaries downloaded from the project to build the project.
> With binaries checked in, it would be all too easy to accidentally get
> in a state where the project can only be built using tools for which the
> source isn't available or working or doesn't quite correspond to the
> binary.
>
> Where is the source used to generate this "build-tools.jar" file, and
> how is that compiled?
>
> Regards,
>
> Simon
>
> Thomas Spiegl wrote:
> > It's just a 9kb file.
> >
> > On 12/19/05, *Simon Kitching* <skitching@obsidium.com
> > <mailto: skitching@obsidium.com>> wrote:
> >
> > tomsp@apache.org <ma...@apache.org> wrote:
> > > Author: tomsp
> > > Date: Sun Dec 18 16:32:06 2005
> > > New Revision: 357582
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
> > <http://svn.apache.org/viewcvs?rev=357582&view=rev>
> > > Log:
> > > facelet support
> > >
> > [snip]
> >
> > >
> > > Added: myfaces/build/trunk/tools/build-tools.jar
> > > URL:
> >
> http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> > <http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> >
> > >
> >
> ==============================================================================
> > > Binary file - no diff available.
> > >
> > > Propchange: myfaces/build/trunk/tools/build-tools.jar
> > >
> >
> ------------------------------------------------------------------------------
> > > svn:mime-type = application/octet-stream
> > >
> > >
> > >
> >
> >
> > I'm not keen on having binary files checked in. Is this really
> > necessary?
> >
> >
> >
> >
> > --
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml
tools/ tools/build-tools.jar tools/src/
Posted by Simon Kitching <sk...@obsidium.com>.
Hi Thomas,
It's not the size; it's the principle of adding binary files that people
must execute in order to build from source (which I presume is what this
jar is for).
I understand that people need to use binary builds of Ant or Maven in
order to build, but nevertheless I'm not aware of any other projects
that require binaries downloaded from the project to build the project.
With binaries checked in, it would be all too easy to accidentally get
in a state where the project can only be built using tools for which the
source isn't available or working or doesn't quite correspond to the binary.
Where is the source used to generate this "build-tools.jar" file, and
how is that compiled?
Regards,
Simon
Thomas Spiegl wrote:
> It's just a 9kb file.
>
> On 12/19/05, *Simon Kitching* <skitching@obsidium.com
> <ma...@obsidium.com>> wrote:
>
> tomsp@apache.org <ma...@apache.org> wrote:
> > Author: tomsp
> > Date: Sun Dec 18 16:32:06 2005
> > New Revision: 357582
> >
> > URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
> <http://svn.apache.org/viewcvs?rev=357582&view=rev>
> > Log:
> > facelet support
> >
> [snip]
>
> >
> > Added: myfaces/build/trunk/tools/build-tools.jar
> > URL:
> http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> <http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto>
> >
> ==============================================================================
> > Binary file - no diff available.
> >
> > Propchange: myfaces/build/trunk/tools/build-tools.jar
> >
> ------------------------------------------------------------------------------
> > svn:mime-type = application/octet-stream
> >
> >
> >
>
>
> I'm not keen on having binary files checked in. Is this really
> necessary?
>
>
>
>
> --
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/ tools/build-tools.jar tools/src/
Posted by Sean Schofield <se...@gmail.com>.
I agree with Martin and Simon on this one. Maybe this can be resolved
in the new Maven build?
sean
On 12/18/05, Martin Cooper <ma...@apache.org> wrote:
>
>
> On 12/18/05, Thomas Spiegl <th...@gmail.com> wrote:
> > It's just a 9kb file.
>
> It's still a jar file, and therefore a build artifact. It shouldn't be
> checked in.
>
> --
> Martin Cooper
>
>
>
> >
> >
> > On 12/19/05, Simon Kitching <sk...@obsidium.com> wrote:
> > > tomsp@apache.org wrote:
> > > > Author: tomsp
> > > > Date: Sun Dec 18 16:32:06 2005
> > > > New Revision: 357582
> > > >
> > > > URL:
> http://svn.apache.org/viewcvs?rev=357582&view=rev
> > > > Log:
> > > > facelet support
> > > >
> > > [snip]
> > >
> > > >
> > > > Added: myfaces/build/trunk/tools/build-tools.jar
> > > > URL:
> http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> > > >
> ==============================================================================
> > > > Binary file - no diff available.
> > > >
> > > > Propchange: myfaces/build/trunk/tools/build-tools.jar
> > > >
> ------------------------------------------------------------------------------
> > > > svn:mime-type = application/octet-stream
> > > >
> > > >
> > > >
> > >
> > >
> > > I'm not keen on having binary files checked in. Is this really
> necessary?
> > >
> > >
> >
> >
> >
> > --
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
>
>
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/ tools/build-tools.jar tools/src/
Posted by Martin Cooper <ma...@apache.org>.
On 12/18/05, Thomas Spiegl <th...@gmail.com> wrote:
>
> It's just a 9kb file.
It's still a jar file, and therefore a build artifact. It shouldn't be
checked in.
--
Martin Cooper
On 12/19/05, Simon Kitching <sk...@obsidium.com> wrote:
> >
> > tomsp@apache.org wrote:
> > > Author: tomsp
> > > Date: Sun Dec 18 16:32:06 2005
> > > New Revision: 357582
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
> > > Log:
> > > facelet support
> > >
> > [snip]
> >
> > >
> > > Added: myfaces/build/trunk/tools/build-tools.jar
> > > URL:
> > http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> > >
> > ==============================================================================
> > > Binary file - no diff available.
> > >
> > > Propchange: myfaces/build/trunk/tools/build-tools.jar
> > >
> > ------------------------------------------------------------------------------
> > > svn:mime-type = application/octet-stream
> > >
> > >
> > >
> >
> >
> > I'm not keen on having binary files checked in. Is this really
> > necessary?
> >
> >
>
>
> --
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/ tools/build-tools.jar tools/src/
Posted by Thomas Spiegl <th...@gmail.com>.
It's just a 9kb file.
On 12/19/05, Simon Kitching <sk...@obsidium.com> wrote:
>
> tomsp@apache.org wrote:
> > Author: tomsp
> > Date: Sun Dec 18 16:32:06 2005
> > New Revision: 357582
> >
> > URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
> > Log:
> > facelet support
> >
> [snip]
>
> >
> > Added: myfaces/build/trunk/tools/build-tools.jar
> > URL:
> http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> >
> ==============================================================================
> > Binary file - no diff available.
> >
> > Propchange: myfaces/build/trunk/tools/build-tools.jar
> >
> ------------------------------------------------------------------------------
> > svn:mime-type = application/octet-stream
> >
> >
> >
>
>
> I'm not keen on having binary files checked in. Is this really necessary?
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml
tools/ tools/build-tools.jar tools/src/
Posted by Simon Kitching <sk...@obsidium.com>.
tomsp@apache.org wrote:
> Author: tomsp
> Date: Sun Dec 18 16:32:06 2005
> New Revision: 357582
>
> URL: http://svn.apache.org/viewcvs?rev=357582&view=rev
> Log:
> facelet support
>
[snip]
>
> Added: myfaces/build/trunk/tools/build-tools.jar
> URL: http://svn.apache.org/viewcvs/myfaces/build/trunk/tools/build-tools.jar?rev=357582&view=auto
> ==============================================================================
> Binary file - no diff available.
>
> Propchange: myfaces/build/trunk/tools/build-tools.jar
> ------------------------------------------------------------------------------
> svn:mime-type = application/octet-stream
>
>
>
I'm not keen on having binary files checked in. Is this really necessary?