You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2018/06/10 07:08:42 UTC

[kylin] branch master updated: KYLIN-3398 Fix inaccurate arithmetic operations in LookupTableToHFileJob#calculateShardNum

This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/master by this push:
     new ff122eb  KYLIN-3398 Fix inaccurate arithmetic operations in LookupTableToHFileJob#calculateShardNum
ff122eb is described below

commit ff122ebdde3a2486bede103c589e0aa4149e1658
Author: nichunen <ch...@kyligence.io>
AuthorDate: Sun Jun 10 14:25:55 2018 +0800

    KYLIN-3398 Fix inaccurate arithmetic operations in LookupTableToHFileJob#calculateShardNum
---
 .../org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
index 39ebe99..054e146 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
@@ -233,8 +233,8 @@ public class LookupTableToHFileJob extends AbstractHadoopJob {
     }
 
     private int calculateShardNum(KylinConfig kylinConfig, long dataSize) {
-        long shardSize = kylinConfig.getExtTableSnapshotShardingMB() * 1024 * 1024;
-        return dataSize < shardSize ? 1 : (int) (Math.ceil(dataSize / shardSize));
+        long shardSize = (long) (kylinConfig.getExtTableSnapshotShardingMB()) * 1024 * 1024;
+        return dataSize < shardSize ? 1 : (int) (Math.ceil((double) dataSize / shardSize));
     }
 
     private byte[][] getSplitsByShardNum(int shardNum) {

-- 
To stop receiving notification emails like this one, please contact
shaofengshi@apache.org.