You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/12/14 12:21:38 UTC
[GitHub] [plc4x] frido opened a new issue, #694: Implement custom exception handling in TriggeredScraperTask
frido opened a new issue, #694:
URL: https://github.com/apache/plc4x/issues/694
If there is exception while scraping, the exception is logged on the DEBUG level.
https://github.com/apache/plc4x/blob/d2e3dcafee07b9406489bd02c84b1f8fe432601f/plc4j/tools/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScraperTask.java#L204
The user can override this `handleException(Exception e)` method, but it is not possible to pass custom implementation of `TriggeredScraperTask` to the `TriggeredScraperImpl`.
There is hard-coded `TriggeredScraperTask` class:
https://github.com/apache/plc4x/blob/d2e3dcafee07b9406489bd02c84b1f8fe432601f/plc4j/tools/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/TriggeredScraperImpl.java#L202
It should be possible to set something like _task factory_ to the `TriggeredScraperImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement custom exception handling in TriggeredScraperTask
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz closed issue #694: Implement custom exception handling in TriggeredScraperTask
URL: https://github.com/apache/plc4x/issues/694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on issue #694: Implement custom exception handling in TriggeredScraperTask
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on issue #694:
URL: https://github.com/apache/plc4x/issues/694#issuecomment-1358999111
Yeah ... unfortunately the scraper is sort of a part we are planning on rewriting as the original author is no longer seriously active here and we're not too happy with parts of it. Would this be something you would be willing to help with? I know we just recently had someone step up raising his hand for starting to clean up this part. Perhaps something you could join in on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement custom exception handling in TriggeredScraperTask
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #694:
URL: https://github.com/apache/plc4x/issues/694#issuecomment-2293347900
Hmmm ... are we really waiting for feedback here? If not, I think we can close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org