[GitHub] [spark] rangadi commented on a diff in pull request #40586: [SPARK-42939][SS][CONNECT] Core streaming Python API for Spark Connect

["rangadi (via GitHub)" <gi...@apache.org>]

rangadi commented on code in PR #40586:
URL: https://github.com/apache/spark/pull/40586#discussion_r1156212372


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -154,6 +158,9 @@ message Read {
     //
     // This is only supported by the JDBC data source.
     repeated string predicates = 5;
+
+    // (Optional) Source table name for a streaming read. Not used in batch read.
+    string streaming_table_name = 6;

Review Comment:
   NamedTable does not take options. It is not yet usable for Streaming yet. 
   
   
   >  A read with [NamedTable](https://github.com/apache/spark/blob/42481a047b34c39b1feaf5a9081b6c3432409bae/connector/connect/common/src/main/protobuf/spark/connect/relations.proto#L122-L125) does not take any options in spark-connect. This is unlike [DataSource](https://github.com/apache/spark/blob/42481a047b34c39b1feaf5a9081b6c3432409bae/connector/connect/common/src/main/protobuf/spark/connect/relations.proto#L127). Is that intentional? The interface allows specifying options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org